Skip to content

fix(net): expose createServer helper exports#2722

Merged
proggeramlug merged 3 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-2703-net-create-server-manifest
May 29, 2026
Merged

fix(net): expose createServer helper exports#2722
proggeramlug merged 3 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-2703-net-create-server-manifest

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

  • add node:net createServer, callable Server, _normalizeArgs, and _createServerHandle to the API manifest and generated docs
  • expose the target net exports as enumerable callable namespace properties with Node-compatible arities
  • implement deterministic _normalizeArgs overload normalization and add parity coverage for the export shape

Fixes #2703

Verification

  • cargo fmt --all -- --check
  • RUSTC_WRAPPER= cargo check -p perry-api-manifest -p perry-hir -p perry-codegen -p perry-runtime
  • RUSTC_WRAPPER= cargo test -p perry-codegen --test manifest_consistency
  • RUSTC_WRAPPER= cargo test -p perry-api-manifest
  • PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH RUSTC_WRAPPER= ./run_parity_tests.sh --suite node-suite --module net --filter create-server-and-helpers
  • PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH RUSTC_WRAPPER= ./run_parity_tests.sh --suite node-suite --module net
  • RUSTC_WRAPPER= ./scripts/regen_api_docs.sh
  • jq empty test-parity/known_failures.json test-parity/threshold.json
  • git diff --check --cached && git diff --check
  • ./scripts/check_file_size.sh

Ralph Küpper added 2 commits May 30, 2026 00:10
# Conflicts:
#	docs/api/perry.d.ts
#	docs/src/api/reference.md
# Conflicts:
#	crates/perry-runtime/src/object/native_module.rs
#	docs/api/perry.d.ts
#	docs/src/api/reference.md
@proggeramlug proggeramlug merged commit 5986db3 into PerryTS:main May 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node:net: expose createServer and internal helper exports in the API manifest

2 participants