fix(fs): throw opendir errors for invalid paths#2965
Merged
proggeramlug merged 1 commit intoMay 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.opendirSync()path arguments before decodingread_dirfailures as Node-shapedopendirfs errors instead of returning empty Dir objectsfs.opendir()through the same helper so regular-file paths callback withENOTDIRCloses #2943.
Tests
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH node --experimental-strip-types test-parity/node-suite/fs/readdir/opendir-invalid-paths.tsopendirSync missing no-throw true:test-parity/reports/parity_report_20260530_033305.jsonPATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH RUSTC_WRAPPER= ./run_parity_tests.sh --suite node-suite --module fs/readdir --filter opendircargo fmt --all -- --checkjq empty test-parity/known_failures.json test-parity/threshold.jsongit diff --check && git diff --cached --check./scripts/check_file_size.shRUSTC_WRAPPER= cargo check -p perry-runtime