Skip to content

fix(perf_hooks): align timing and validation semantics#3508

Merged
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-perf-hooks-timing-validation
May 31, 2026
Merged

fix(perf_hooks): align timing and validation semantics#3508
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-perf-hooks-timing-validation

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

These issues are batched because they share the same node:perf_hooks runtime module and several fixes need matching dispatch/lowering changes to stay coherent.

Verification

  • PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module perf_hooks passed: 78 parity pass, 0 parity fail, 0 compile fail. Report: test-parity/reports/parity_report_20260531_024703.json
  • RUSTC_WRAPPER= cargo check -p perry-runtime -p perry-codegen -p perry-hir -p perry-api-manifest -p perry passed with existing warnings.
  • cargo fmt --all -- --check passed.
  • ./scripts/check_file_size.sh passed.
  • jq empty test-parity/known_failures.json passed.
  • git diff HEAD~1..HEAD --check passed.

Non-goals

  • This does not add broader event-loop instrumentation beyond the deterministic eventLoopUtilization shape and diff behavior covered here.

# Conflicts:
#	crates/perry-runtime/src/perf_hooks.rs
@proggeramlug proggeramlug merged commit c553a51 into PerryTS:main May 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment