fix(url): coerce WHATWG string arguments#3512
Merged
proggeramlug merged 2 commits intoMay 31, 2026
Merged
Conversation
This was referenced May 31, 2026
# Conflicts: # crates/perry-codegen/src/expr/url_main.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String(value)coercion path so booleans, nullish values, objects, and symbols match Node behavior.has()anddelete().domainToASCII()anddomainToUnicode()inputs before IDNA conversion.Why Batched
These issues share the same WHATWG URL string-conversion boundary. Fixing them together keeps runtime FFI, codegen lowering, dynamic URL property assignment, and parity coverage consistent.
Verification
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module url --filter coercionfailed 0/3. Report:test-parity/reports/parity_report_20260531_025714.jsonPATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module urlpassed 61/61, 0 fail, 0 compile fail. Report:test-parity/reports/parity_report_20260531_032208.jsonRUSTC_WRAPPER= cargo check -p perry-runtime -p perry-codegen -p perry-hir -p perry-api-manifest -p perrypassed with existing warnings.cargo fmt --all -- --checkpassed../scripts/check_file_size.shpassed.jq empty test-parity/known_failures.jsonpassed.git diff HEAD~1..HEAD --checkpassed.Known Limitations / Non-goals
url.parse(),url.format(), or file URL path conversion behavior.