fix(node:url): expose legacy Url and form encoding#3692
Merged
proggeramlug merged 4 commits intoMay 31, 2026
Merged
Conversation
andrewtdiz
force-pushed
the
codex/node-compat-url-legacy-http-options
branch
2 times, most recently
from
d86b133 to
01f30ac
Compare
andrewtdiz
force-pushed
the
codex/node-compat-url-legacy-http-options
branch
from
01f30ac to
cdd4b5e
Compare
added 3 commits
May 31, 2026 15:53
# Conflicts: # crates/perry-runtime/src/object/native_module.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
url.Urlas a constructible/callable native export with Node's legacy key order and null defaultsurl.resolveObjectdispatch, lowering, manifest, and docs supportURLSearchParamsserialization with the WHATWG form encode set used by Node (~escapes,*stays literal)Closes #2686.
Closes #2978.
Tests
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH node --experimental-strip-types test-parity/node-suite/url/module/legacy-url-exports.ts > /tmp/perry-node-legacy-url-exports.out && diff -u test-parity/expected/legacy-url-exports.txt /tmp/perry-node-legacy-url-exports.outPATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH node --experimental-strip-types test-parity/node-suite/url/search-params/form-encode-set.ts > /tmp/perry-node-form-encode-set.out && diff -u test-parity/expected/form-encode-set.txt /tmp/perry-node-form-encode-set.outPERRY_NO_AUTO_OPTIMIZE=1 PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module url --filter legacy-url-exportsPERRY_NO_AUTO_OPTIMIZE=1 PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module url --filter form-encode-setcargo test -p perry-codegen --test manifest_consistencycargo fmt --all -- --checkgit diff origin/main..HEAD --check./scripts/check_file_size.shjq empty test-parity/known_failures.json