fix(node): add constants metadata tail parity#3705
Merged
proggeramlug merged 3 commits intoMay 31, 2026
Conversation
added 2 commits
May 31, 2026 14:57
# Conflicts: # crates/perry-runtime/src/object/native_module.rs # docs/api/perry.d.ts # docs/src/api/reference.md
# Conflicts: # docs/api/perry.d.ts # docs/src/api/reference.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3683.
Summary
node:constantsmetadata tail for libuv dirent/symlink/copyfile constants, POSIX file type/permission masks, selected POSIX open flags, anddefaultCoreCipherList.fs.constants, andcrypto.constants.defaultCoreCipherListstay aligned.Why batched
These entries are one constants metadata cluster: they use the same native module constant table, enumeration list, manifest exports, and import/parity surface. Keeping them together avoids repeated churn through the same generated docs and manifest paths.
Tests added
test-parity/node-suite/constants/imports/metadata-tail.tscovers default/namespace/named import parity, enumerable keys, Linux open flag values,fs.constantsalignment, LinuxO_SYMLINKabsence, anddefaultCoreCipherListshape.Verification
TMPDIR="$PWD/target/tmp" PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module constants- PASS 2/2, reporttest-parity/reports/parity_report_20260531_120700.jsonTMPDIR="$PWD/target/tmp" CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= cargo check -p perry-runtime -p perry-codegen -p perry-api-manifest- PASSTMPDIR="$PWD/target/tmp" CARGO_BUILD_JOBS=1 RUSTC_WRAPPER= cargo test -p perry-codegen --test manifest_consistency- PASS 4/4cargo fmt --all -- --check- PASSgit diff --check HEAD- PASS./scripts/check_file_size.sh- PASSNon-goals
fs.constantsvalues, andcrypto.constants.defaultCoreCipherList.