feat(crypto): expose getCipherInfo via manifest (#3955)#4068
Merged
Conversation
Runtime impl (js_crypto_get_cipher_info) and dispatch already existed; only the perry-api-manifest row was missing, so the #463 unimplemented-API gate rejected crypto.getCipherInfo(). Add the method() entry and regenerate API docs.
proggeramlug
force-pushed
the
cycle48-getcipherinfo
branch
from
bb9666b to
2d19432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crypto.getCipherInfo()was rejected by the #463 unimplemented-API gate even though its runtime implementation (js_crypto_get_cipher_info) and native dispatch already existed — theperry-api-manifestwas simply missing the row.This adds the
method("crypto", "getCipherInfo", false, None)entry and regenerates the API docs.Fixes #3955.
Validation
Built
-p perryat 0.5.1099 and verified both node-suite fixtures matchnode --experimental-strip-typesbyte-for-byte (compiled-to-binary to avoid auto-optimize compile noise):crypto/cipher/get-cipher-info.ts— MATCH (17 lines)crypto/cipher/get-cipher-info-ecb-wrap.ts— MATCH (14 lines)cargo fmt --all -- --checkclean. Docs regenerated viascripts/regen_api_docs.sh(onlygetCipherInfoadded; #3869's readline entries preserved).