[codex] crypto: expose implemented helper exports#4123
Merged
proggeramlug merged 1 commit intoJun 2, 2026
Merged
Conversation
This was referenced Jun 2, 2026
4a413c4 to
31b7b55
Compare
cc5b3d0 to
21a8be7
Compare
21a8be7 to
6e2d056
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes implemented
node:cryptohelpers through the API manifest and namespace callable paths.DiffieHellman,DiffieHellmanGroup,diffieHellman, async key/prime helpers, FIPS/secure heap,hkdf, andscrypt.newcall shapes.diffieHellmanexport parity.Closes #2694.
Closes #2706.
Closes #2716.
Validation
NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter dh(21/21 pass)NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter export-aliases(1/1 pass)NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter module-function-names(1/1 pass)NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter fips-api(1/1 pass)NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter secure-heap-used(1/1 pass)NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter generate-check(1/1 pass)NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter generate-key(11/11 pass)NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter hkdf(6/6 pass)NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter scrypt(3/3 pass)cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shCARGO_TERM_COLOR=never cargo check -p perry-api-manifest -p perry-runtime -p perry-stdlib -p perry-hir -p perry-codegen./scripts/regen_api_docs.sh