Skip to content

[codex] crypto: expose implemented helper exports#4123

Merged
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-crypto-manifest-exports
Jun 2, 2026
Merged

[codex] crypto: expose implemented helper exports#4123
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-crypto-manifest-exports

Conversation

@andrewtdiz
Copy link
Copy Markdown
Contributor

Summary

Exposes implemented node:crypto helpers through the API manifest and namespace callable paths.

  • Adds manifest/docs entries for implemented crypto helpers including DiffieHellman, DiffieHellmanGroup, diffieHellman, async key/prime helpers, FIPS/secure heap, hkdf, and scrypt.
  • Routes DH constructor aliases through the existing classic-DH factories for named, namespace, and new call shapes.
  • Adds runtime callable dispatch fallbacks for captured crypto namespace helper calls.
  • Adds a parity fixture covering DH constructor aliases and one-shot diffieHellman export parity.

Closes #2694.
Closes #2706.
Closes #2716.

Validation

  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter dh (21/21 pass)
  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter export-aliases (1/1 pass)
  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter module-function-names (1/1 pass)
  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter fips-api (1/1 pass)
  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter secure-heap-used (1/1 pass)
  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter generate-check (1/1 pass)
  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter generate-key (11/11 pass)
  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter hkdf (6/6 pass)
  • NODE25_DIR=$(dirname "$(npx -y node@25 -p 'process.execPath')"); PATH="$NODE25_DIR:$PATH" ./run_parity_tests.sh --suite node-suite --module crypto --filter scrypt (3/3 pass)
  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh
  • CARGO_TERM_COLOR=never cargo check -p perry-api-manifest -p perry-runtime -p perry-stdlib -p perry-hir -p perry-codegen
  • ./scripts/regen_api_docs.sh

@andrewtdiz andrewtdiz force-pushed the codex/node-compat-crypto-manifest-exports branch from 4a413c4 to 31b7b55 Compare June 2, 2026 17:28
@andrewtdiz andrewtdiz marked this pull request as ready for review June 2, 2026 17:28
@andrewtdiz andrewtdiz force-pushed the codex/node-compat-crypto-manifest-exports branch 2 times, most recently from cc5b3d0 to 21a8be7 Compare June 2, 2026 17:42
@proggeramlug proggeramlug force-pushed the codex/node-compat-crypto-manifest-exports branch from 21a8be7 to 6e2d056 Compare June 2, 2026 19:13
@proggeramlug proggeramlug merged commit 690e22d into PerryTS:main Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants