Fix prototype and super assignment parity#4233
Merged
proggeramlug merged 2 commits intoJun 3, 2026
Merged
Conversation
4044338 to
80c43e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super[property] = valueusing parent-prototype lookup with the current receiver[[Set]]path, including setter alias registration and implicit-this scopingSuperPropertySetout of the generic inliner so the method receiver is not lostreference/deepwiki/Verification
cargo fmt --checkgit diff --checkcargo check -p perry-transform -p perry-hir -p perry-codegen -p perry-runtimecargo build -p perry -p perry-runtime -p perry-stdlibtests/test_c262_assignment_parity.sh->PASSpython3 scripts/test262_focused_report.py --root vendor/test262 --perry-bin target/debug/perry --dir language/expressions/assignment --max 80 --sample-cap 1000000 --skip-build-> pass=74, diff=0, runtime-fail=6, compile-fail=0, parity=92.5%Remaining Assignment Slice Buckets
language/expressions/assignment/8.14.4-8-b_1.js: Object.defineProperty called on non-objectlanguage/expressions/assignment/8.14.4-8-b_2.js: Object.defineProperty called on non-objectlanguage/expressions/assignment/S11.13.1_A5_T1.js: Perry ran clean; Node rejectedlanguage/expressions/assignment/S11.13.1_A5_T2.js: Perry ran clean; Node rejectedlanguage/expressions/assignment/S11.13.1_A7_T4.js: Expected true but got falselanguage/expressions/assignment/destructuring/keyed-destructuring-property-reference-target-evaluation-order-with-bindings.js: runtime panic infield_get_set.rsNotes
[[Set]]behavior: inherited setter receiver, computed super key-before-RHS ordering, static-super preservation, and inherited getter-only write rejection without creating an own property.