[codex] expose X509 extension metadata#4241
Merged
proggeramlug merged 1 commit intoJun 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #2563.
Adds a focused X509Certificate extension-metadata slice:
X509Certificate#subjectAltNamefor deterministic DNS/IP/email/URI SAN entriesX509Certificate#keyUsageas Node 26-shaped Extended Key Usage OID arraysundefinedScope
The implementation decodes the existing parsed X509 handle's extensions with RustCrypto
x509-certtypes and routes the two new properties through the handle property dispatcher.This intentionally follows the Node 26 observed
keyUsageshape for Extended Key Usage OIDs, not a broader Basic Key Usage flag surface.Non-goals
Still intentionally outside this slice:
checkHost()/checkEmail()/checkIP(), certificate/key verification,publicKey,issuerCertificate,infoAccess, andtoLegacyObject().Verification
npm exec --package=node@26 -- node test-parity/node-suite/crypto/x509/extension-metadata.tsCARGO_TARGET_DIR=/tmp/perry-node-x509-check-target cargo check -p perry-stdlib --no-default-features --features cryptoCARGO_TARGET_DIR=/tmp/perry-node-x509-check-target npm exec --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module crypto --filter extension-metadata'PERRY_NO_AUTO_OPTIMIZE=1 CARGO_TARGET_DIR=/tmp/perry-node-x509-check-target npm exec --package=node@26 -- bash -lc './run_parity_tests.sh --suite node-suite --module crypto --filter x509'cargo fmt --all -- --checkgit diff --check./scripts/check_file_size.sh