Skip to content

[codex] consume HTTP upgrade WebSocket frames in parity fixture #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Jun 3, 2026
Merged

[codex] consume HTTP upgrade WebSocket frames in parity fixture #4251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions test-parity/node-suite/http/server/upgrade-websocket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,18 @@ function unmaskedTextFrame(text: string) {
return Buffer.concat([Buffer.from([0x81, payload.length]), payload]);
}

function readServerTextFrame(buf: Buffer) {
const start = buf.indexOf(Buffer.from([0x81]));
if (start < 0 || start + 2 > buf.length) return "";
const len = buf[start + 1] & 0x7f;
if (start + 2 + len > buf.length) return "";
return buf.slice(start + 2, start + 2 + len).toString("utf8");
function readServerFrame(buf: Buffer) {
if (buf.length < 2) return null;
const opcode = buf[0] & 0x0f;
const len = buf[1] & 0x7f;
if (len >= 126) return null;
const frameLength = 2 + len;
if (buf.length < frameLength) return null;
return {
opcode,
text: opcode === 1 ? buf.slice(2, frameLength).toString("utf8") : "",
bytes: frameLength,
};
}

function readClientTextFrame(frame: Buffer) {
Expand Down Expand Up @@ -107,11 +113,15 @@ client.on("data", (chunk: Buffer) => {
pending = pending.slice(marker + 4);
client.write(maskedTextFrame("hello"));
}
const text = readServerTextFrame(pending);
if (text) {
console.log("client-frame:", text);
client.end();
server.close();
while (pending.length > 0) {
const frame = readServerFrame(pending);
if (!frame) break;
pending = pending.slice(frame.bytes);
if (frame.text) {
console.log("client-frame:", frame.text);
client.end();
server.close();
}
}
});

Expand Down