fix(crypto): check x509 private keys#4303
Merged
proggeramlug merged 1 commit intoJun 4, 2026
Merged
Conversation
0a61ad9 to
ed82cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X509Certificate#checkPrivateKey(privateKey)dispatch and property exposurepkeyas a KeyObject and rejects public/secret KeyObjects with Node-shapedERR_INVALID_ARG_VALUEtruefor the matching RSA private key andfalsefor mismatched RSA or unsupported non-RSA private keysNon-goals
checkIssued()issuerCertificateinfoAccessverify()covered by separate draft PR fix(crypto): verify x509 certificates with public keys #4300Validation
cargo fmt --all --checknpm exec --package=node@26 -- node --experimental-strip-types test-parity/node-suite/crypto/x509/check-private-key.tsCARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-x509-check-private-key-check cargo check -p perry-stdlib --no-default-features --features cryptoCARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-x509-check-private-key-build cargo build -p perry --releaseCARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-x509-check-private-key-build cargo build -p perry-runtime -p perry-stdlib --releasetest-parity/node-suite/crypto/x509/check-private-key.tsPATH=<node26-bin>:$PATH CARGO_TARGET_DIR=/root/perry-worktrees/.build-targets/perry-x509-check-private-key-build PERRY_RUNTIME_DIR=/root/perry-worktrees/.build-targets/perry-x509-check-private-key-build/release PERRY_NO_AUTO_OPTIMIZE=1 PERRY_GEN_GC=0 ./run_parity_tests.sh --suite node-suite --module crypto --filter x509/check-private-keygit diff --check./scripts/check_file_size.sh