feat(ui): close 5 sharity-port UI gaps #706/#707/#708/#709/#710#716
Merged
Conversation
….866) - #706 bottomNavSetTintColor / bottomNavSetUnselectedTintColor — iOS UITabBar.tintColor + unselectedItemTintColor; macOS overrides the custom NSStackView's per-tab tint pass in apply_styling - #707 textSetNumberOfLines / textSetTruncationMode — UILabel.numberOfLines + lineBreakMode; macOS NSTextField.maximumNumberOfLines + cell wrap + lineBreakMode. Mode 0=word-wrap, 1=head, 2=middle, 3=tail - #708 iOS alertWithButtons — new perry-ui-ios/src/widgets/alert.rs uses UIAlertController + per-button UIAlertAction RcBlock handlers, presented on topmost VC via main-queue dispatch - #709 iOS Button \n support — titleLabel.numberOfLines=0 + center + wordWrap unconditionally; single-line labels unchanged - #710 AttributedText builder — per-handle NSMutableAttributedString accumulator with appendAttributedString runs (NSFont/NSColor/NSUnderline); iOS UILabel via setAttributedText, macOS NSTextField via setAttributedStringValue. Stubs on other platforms. Plumbing: new perry-dispatch MethodRow entries + perry-api-manifest entries + types/perry/ui/index.d.ts exports. Workspace tests pass (0 failed). Smoke test compiles + launches.
…indows/Android/watchOS (v0.5.867) Replaces the v0.5.866 cross-platform stubs with actual implementations: - tvOS / visionOS: UIKit-based — copied alert.rs / attributed_text.rs / bottom_nav.rs from iOS (same UIKit API surface). Also fixed pre-existing ABI bug in visionOS perry_ui_alert (was i64 instead of f64 for buttons) and added the missing alert_simple symbol. - GTK4: bottom_nav tint via Pango AttrColor on labels; text setters via GtkLabel.set_lines + ellipsize; AttributedText via Pango AttrList per-run. - Windows: bottom_nav tint stored on NavEntry + InvalidateRect (visual application waits on owner-drawn button rewrite — Win32 BUTTON ignores WM_CTLCOLORBTN); text setters via SS_*ELLIPSIS style bits; AttributedText via RichEdit50W + EM_SETCHARFORMAT runs. - Android: bottom_nav tint stored on BottomNavState + applied via setColorFilter/setTextColor; text setters via TextView.setMaxLines + setEllipsize; AttributedText via SpannableStringBuilder + StyleSpan / UnderlineSpan / ForegroundColorSpan / AbsoluteSizeSpan. - watchOS: new NodeData fields + NodeKind::AttributedText variant + 9 new perry_watchos_node_attr_run_* introspection FFI symbols; SwiftUI host will apply via .lineLimit / .truncationMode / Text concat. Workspace tests pass; cargo fmt clean.
proggeramlug
force-pushed
the
worktree-fix-706-710-ui-gaps
branch
from
14f99a3 to
81e88f4
Compare
proggeramlug
added a commit
that referenced
this pull request
May 12, 2026
PR #716 added crates/perry-ui-gtk4/src/widgets/attributed_text.rs with pango Attribute construction that doesn't compile against the pango-rs sub-attribute type hierarchy. `AttrInt::new_weight()` etc. return concrete subtype (AttrInt, AttrSize, AttrColor); the push closure expects the parent `pango::Attribute`. Need explicit .upcast() per the glib type system. The error didn't surface on #716's CI because the gtk4 doc-tests matrix entry is disabled (v0.5.874 timeouts), and the release build matrix is the only path that builds perry-ui-gtk4 cross-arch. Surfaced on v0.5.888's release run. 5 sites updated. Uses gtk4::glib::object::Cast trait import.
proggeramlug
added a commit
that referenced
this pull request
May 12, 2026
…0.5.890)
v0.5.889's pango upcast was correct but `BUFFERS.with(|b| ...)` used
`b` as the closure parameter, shadowing the outer fn's `b: f64`
(blue color component). Line 119's `to16(b)` resolved to the
closure's RefCell instead of the f64 — E0308 mismatched-types
("expected f64, found &RefCell<HashMap<i64, Buffer>>").
Renamed closure binding to `bufs`. Same shape as the workaround
v0.5.889 added the .upcast() for.
Also fallout from PR #716.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #706, #707, #708, #709, #710 — all five gaps from the sharity-app port.
bottomNavSetTintColor/bottomNavSetUnselectedTintColor— iOSUITabBar.tintColor+unselectedItemTintColor, macOS overrides the custom NSStackView's per-tab tint pass. Stubs elsewhere.textSetNumberOfLines/textSetTruncationMode— iOSUILabel.numberOfLines+lineBreakMode, macOSNSTextField.maximumNumberOfLines+ cell wrap +lineBreakMode. Modes: 0=word-wrap, 1=head, 2=middle, 3=tail. Auto-switches to tail whenlines > 0and mode is still the default.alertWithButtons— newcrates/perry-ui-ios/src/widgets/alert.rswithUIAlertController+ per-buttonUIAlertActionRcBlock handlers, presented on the topmost view controller via main-queue dispatch (so it works from any thread and stacks safely above other modals).titleLabel.numberOfLines = 0+textAlignment = center+lineBreakMode = wordWrapunconditionally inButton::create. Single-line labels unchanged.AttributedText— empty widget +attributedTextAppend(widget, text, bold, italic, underline, fontSize, r, g, b, a)+attributedTextClear. Per-handleNSMutableAttributedStringaccumulator; iOSUILabel.setAttributedText:, macOSNSTextField.setAttributedStringValue:. Distinct from perry/ui: rich text editor widget #478 (rich-text editor) — this is the static display surface. Builder pattern instead of the issue'sruns: TextRun[]because the widget runtime has no plumbing for nested JS object fields today.Plumbing: new
perry-dispatchMethodRowentries,perry-api-manifestentries, and.d.tsexports with usage examples. No new HIR variants needed.Test plan
cargo build --release -p perry-runtime -p perry-stdlib -p perrycleancargo build --release -p perry-ui-macos -p perry-dispatch -p perry-api-manifestcleancargo build --release -p perry-ui-ios --target aarch64-apple-ios-simcleancargo fmt --checkclean/tmp/test_706_710_smoke.tsexercises all new APIs — compiles + binary launches AppKitextern "C" fnso should be safe)