Added connectTime and connectDuration fields to Call and fixed bug wi…#9
Merged
Added connectTime and connectDuration fields to Call and fixed bug wi…#9
Conversation
…th incorrect field name for Call duration
Deseao
requested changes
Apr 17, 2019
Contributor
Deseao
left a comment
Deseao
left a comment
There was a problem hiding this comment.
Please add a way to track the version.
|
Code Climate has analyzed commit 93e486a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.1% (0.1% change). View more on Code Climate. |
Deseao
approved these changes
Apr 17, 2019
Contributor
|
Please go ahead and make a 1.0.0 release off of master when this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…th incorrect field name for Call duration