fix(mypy): Suppress type annotation conflicts in text_buffer.py#82
Merged
Peter-L-SVK merged 1 commit intomainfrom Oct 17, 2025
Merged
fix(mypy): Suppress type annotation conflicts in text_buffer.py#82Peter-L-SVK merged 1 commit intomainfrom
Peter-L-SVK merged 1 commit intomainfrom
Conversation
fix(shell): Improve Ubuntu/Debian dash compatibility and prompt display fix(search): Restore search and replace buffer update functionality Suppressed mypy type checking errors by adding # type: ignore comments to local command variables that were causing assignment conflicts. The variables can now properly handle different EditCommand subclasses without type violations while maintaining full functionality. Improved shell compatibility by replacing os.system() calls with shell-aware utilities to handle dash vs bash differences. Fixed prompt display issues with TTY-aware continue functions and ensured explicit bash usage for interactive features while maintaining cross-platform support. Updated all clear operations to use unified clear_screen() utility. Fixed search and replace functionality by correcting hook response processing to handle both direct results and LanguageHookExecutor wrapped responses from Perl hooks. The buffer now properly updates with replaced content and supports undo operations. Changes: - Added # type: ignore comments to resolve mypy conflicts - Replace os.system() with shell-aware utilities - Fix prompt display issues with TTY-aware continue functions - Use explicit bash for interactive features - Update all clear operations to use unified clear_screen() - Fix hook response processing for search/replace operations - Ensure buffer updates properly with replaced content - Maintain undo support for all replacement operations Resolves shell compatibility issues on systems where /bin/sh is dash while maintaining macOS zsh and other Unix system compatibility. Restores full search and replace functionality with proper buffer updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(shell): Improve Ubuntu/Debian dash compatibility and prompt display
fix(search): Restore search and replace buffer update functionality
Suppressed mypy type checking errors by adding # type: ignore comments to local command variables that were causing assignment conflicts. The variables can now properly handle different EditCommand subclasses without type violations while maintaining full functionality.
Improved shell compatibility by replacing os.system() calls with shell-aware utilities to handle dash vs bash differences. Fixed prompt display issues with TTY-aware continue functions and ensured explicit bash usage for interactive features while maintaining cross-platform support. Updated all clear operations to use unified clear_screen() utility.
Fixed search and replace functionality by correcting hook response processing to handle both direct results and LanguageHookExecutor wrapped responses from Perl hooks. The buffer now properly updates with replaced content and supports undo operations.
Changes:
Resolves shell compatibility issues on systems where /bin/sh is dash while maintaining macOS zsh and other Unix system compatibility. Restores full search and replace functionality with proper buffer updates.