Skip to content

Add additional from_string variants #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
Merged

Add additional from_string variants #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f0b0d7
Add additional from_string variants
PeterCDMcLean Aug 8, 2025
39609ad
clang format
PeterCDMcLean Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions include/bitlib/bit-algorithms/to_from_string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// ================================= array_REF =================================== //
// ============================= to_from_string ============================= //
// Project: The Experimental Bit Algorithms Library
// \file to_string.hpp
// Description: Implementation of array_ref
// \file to_from_string.hpp
// Description: Implementation of to_string and from_string
// Creator: Vincent Reverdy
// Contributor: Peter McLean [2025]
// License: BSD 3-Clause License
Expand Down Expand Up @@ -275,7 +275,7 @@ constexpr CharIt to_string(
return to_string(bits, str_first, str_last, meta);
}

template <typename CharIt, typename RandomAccessIt, typename Policy = policy::typical<typename RandomAccessIt::value_type>>
template <typename CharIt, typename RandomAccessIt, typename Policy = policy::typical<typename std::iterator_traits<RandomAccessIt>::value_type>>
constexpr void from_string(
const CharIt str_first, const CharIt str_last,
const bit_iterator<RandomAccessIt>& bit_first, const bit_iterator<RandomAccessIt>& bit_last,
Expand Down Expand Up @@ -356,7 +356,7 @@ constexpr void from_string(
template <string::metadata_t meta = string::typical(),
typename CharIt,
typename RandomAccessIt,
typename Policy = policy::typical<typename RandomAccessIt::value_type>>
typename Policy = policy::typical<typename std::iterator_traits<RandomAccessIt>::value_type>>
constexpr void from_string(
const CharIt str_first, const CharIt str_last,
const bit_iterator<RandomAccessIt>& bit_first, const bit_iterator<RandomAccessIt>& bit_last) {
Expand Down Expand Up @@ -410,15 +410,15 @@ constexpr std::vector<uintptr_t> from_string(
return from_string(first, last, meta);
}

template <string::metadata_t meta = string::typical(), typename RandomAccessIt, typename Policy = policy::typical<typename RandomAccessIt::value_type>>
template <string::metadata_t meta = string::typical(), typename RandomAccessIt, typename Policy = policy::typical<typename std::iterator_traits<RandomAccessIt>::value_type>>
constexpr void from_string(
const std::string& str,
const bit_iterator<RandomAccessIt>& bit_first, const bit_iterator<RandomAccessIt>& bit_last) {
static_assert(meta.endian == std::endian::big, "Only bit big endian support (MSB on the left)");
from_string<meta, RandomAccessIt, Policy>(str.c_str(), str.c_str() + str.length(), bit_first, bit_last);
}

template <string::metadata_t meta = string::typical(), bit_range RangeT, typename Policy = policy::typical<typename std::ranges::iterator_t<RangeT>::value_type>>
template <string::metadata_t meta = string::typical(), bit_range RangeT, typename Policy = policy::typical<typename std::ranges::iterator_t<RangeT>::word_type>>
constexpr void from_string(
const std::string& str,
RangeT&& bits) {
Expand All @@ -427,7 +427,7 @@ constexpr void from_string(
from_string<meta, std::string::const_iterator, RandomAccessIt, Policy>(str.begin(), str.end(), bits.begin(), bits.end());
}

template <typename RandomAccessIt, typename Policy = policy::typical<typename RandomAccessIt::value_type>>
template <typename RandomAccessIt, typename Policy = policy::typical<typename std::iterator_traits<RandomAccessIt>::value_type>>
constexpr void from_string(
const std::string& str,
const bit_iterator<RandomAccessIt>& bit_first, const bit_iterator<RandomAccessIt>& bit_last,
Expand All @@ -438,7 +438,7 @@ constexpr void from_string(
meta);
}

template <bit_range RangeT, typename Policy = policy::typical<typename std::ranges::iterator_t<RangeT>::value_type>>
template <bit_range RangeT, typename Policy = policy::typical<typename std::ranges::iterator_t<RangeT>::word_type>>
constexpr void from_string(
const std::string& str,
RangeT&& bits,
Expand All @@ -451,6 +451,25 @@ constexpr void from_string(
meta);
}

template <typename CharIt, bit_range RangeT, typename Policy = policy::typical<typename std::ranges::iterator_t<RangeT>::word_type>>
constexpr void from_string(
const CharIt first, const CharIt last,
RangeT&& bits,
string::metadata_t meta = string::typical()) {
using range_iterator_t = std::ranges::iterator_t<RangeT>;
using RandomAccessIt = typename range_iterator_t::iterator_type;
from_string<CharIt, RandomAccessIt, Policy>(first, last, bits.begin(), bits.end(), meta);
}

template <string::metadata_t meta = string::typical(), typename CharIt, bit_range RangeT, typename Policy = policy::typical<typename std::ranges::iterator_t<RangeT>::word_type>>
constexpr void from_string(
const CharIt first, const CharIt last,
RangeT&& bits) {
using range_iterator_t = std::ranges::iterator_t<RangeT>;
using RandomAccessIt = typename range_iterator_t::iterator_type;
return from_string<CharIt, RandomAccessIt, Policy>(first, last, bits.begin(), bits.end(), meta);
}

} // namespace bit

#endif // _BIT_TO_STRING_HPP_INCLUDED
#endif // _BIT_TO_STRING_HPP_INCLUDED
Loading