This repository was archived by the owner on Mar 12, 2022. It is now read-only.
Merged
Conversation
This commit also changes the userId field in the database so that it is no longer a uuid (this was a mistake, Firebase ids are not uuids)
When the user attempts to create a post, they indicate the categories under which the post falls. These may or may not exist. This change changes the createPost controller to create any categories which do not exist.
The reactToPost controller attempted to access req.params.postId, which does not exist. It now correctly uses req.params.id. Additionally, whether the user has or has not liked a post is now correctly calculated, instead of always returning false
a16n-dev
approved these changes
Mar 6, 2022
| const log = Logger.getLogger('verification') | ||
|
|
||
| // function used to determine user authentication | ||
| export default async (token: string) => { |
Collaborator
There was a problem hiding this comment.
Could add this comment back, especially because its an unnamed function it would be nice to have something that indicates what it does without having to rely on the file name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes Made
Brief summary of changes made
Screenshots
Add any screenshots here if applicable