New dataset api#61
Merged
GijsVermarien merged 40 commits intomasterfrom Jun 2, 2021
Merged
Conversation
GJBoth
requested changes
May 14, 2021
Member
GJBoth
left a comment
GJBoth
left a comment
There was a problem hiding this comment.
Two small things; looks good otherwise.
This file is not needed.
Updated the function name.
remykusters
approved these changes
May 17, 2021
Member
remykusters
left a comment
remykusters
left a comment
There was a problem hiding this comment.
Looks good to me! I checked the examples and the documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new dataset api with primary features:
@GJBoth Could you take a look and verify the inner workings of the training.py and the loader itself?
@remykusters @georgestod could you have a look at the documentation and the notebooks?