Skip to content

Allow setting fixed frequency ranges to avoid in uvcontsub#230

Merged
e-koch merged 10 commits intoPhangsTeam:masterfrom
e-koch:uvcontsub_exclude_freqrange
Jul 11, 2024
Merged

Allow setting fixed frequency ranges to avoid in uvcontsub#230
e-koch merged 10 commits intoPhangsTeam:masterfrom
e-koch:uvcontsub_exclude_freqrange

Conversation

@e-koch
Copy link
Copy Markdown
Collaborator

@e-koch e-koch commented Nov 22, 2022

Adds an additional keyword entry for line definitions in config_definitions.txt:

exclude_freq_ranges_ghz: given as a list of list, this gives a set [low, high] frequency range in GHz to avoid when using uvcontsub.
For example:

line_product    hi21cm    {'line_tag':'hi21cm','channel_kms':0.42,'statwt_edge_kms':50.0}
line_product    hi21cm    {'fitorder':0,'combinespw':False,'lines_to_flag':['hi21cm'],'exclude_freq_ranges_ghz':[[1.42002671,1.42078479]]}

This is useful when multiple targets emit in the same transition along a line-of-sight (e.g., Galactic and extragalactic 21-cm HI). The example above sets a fixed v_rad+/-80 km/s avoidance window for Galactic HI.

This appears to working well for our current HI data, and should have no impact on other uses as the keyword is ignored when not present.

FYI @akleroy

@e-koch
Copy link
Copy Markdown
Collaborator Author

e-koch commented Jul 10, 2024

@thomaswilliamsastro mind having a quick look through? This is working in production for the LGLBS HI imaging.

I need to merge this soon for the next round of LGLBS processing, though.

Copy link
Copy Markdown
Collaborator

@thomaswilliamsastro thomaswilliamsastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just noting this also seems to include numpy-related fixes and some CASA import issues

@e-koch
Copy link
Copy Markdown
Collaborator Author

e-koch commented Jul 11, 2024

I'm encountering no issues with my updates to the imports. Please ping if anyone does hit a problem related to these changes!

@e-koch e-koch merged commit b9dc072 into PhangsTeam:master Jul 11, 2024
@e-koch e-koch deleted the uvcontsub_exclude_freqrange branch July 11, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants