Allow setting fixed frequency ranges to avoid in uvcontsub#230
Merged
e-koch merged 10 commits intoPhangsTeam:masterfrom Jul 11, 2024
Merged
Allow setting fixed frequency ranges to avoid in uvcontsub#230e-koch merged 10 commits intoPhangsTeam:masterfrom
e-koch merged 10 commits intoPhangsTeam:masterfrom
Conversation
Match overlapping regions with the target for continuous freq ranges to be excluded.
Collaborator
Author
|
@thomaswilliamsastro mind having a quick look through? This is working in production for the LGLBS HI imaging. I need to merge this soon for the next round of LGLBS processing, though. |
thomaswilliamsastro
approved these changes
Jul 11, 2024
Collaborator
thomaswilliamsastro
left a comment
There was a problem hiding this comment.
Looks good to me! Just noting this also seems to include numpy-related fixes and some CASA import issues
Collaborator
Author
|
I'm encountering no issues with my updates to the imports. Please ping if anyone does hit a problem related to these changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional keyword entry for line definitions in
config_definitions.txt:exclude_freq_ranges_ghz: given as a list of list, this gives a set [low, high] frequency range in GHz to avoid when using uvcontsub.For example:
This is useful when multiple targets emit in the same transition along a line-of-sight (e.g., Galactic and extragalactic 21-cm HI). The example above sets a fixed v_rad+/-80 km/s avoidance window for Galactic HI.
This appears to working well for our current HI data, and should have no impact on other uses as the keyword is ignored when not present.
FYI @akleroy