small update to single dish routines#235
Merged
thomaswilliamsastro merged 4 commits intomasterfrom Sep 19, 2023
Merged
Conversation
Collaborator
Author
e-koch
reviewed
Apr 13, 2023
| num_chan_line = num_chan_scie[np.where(np.array(spws_scie) == spw_line)[0]] | ||
|
|
||
| # AKL - had to cast lists -> array then index with 0 | ||
| freq_rep_line = np.array(freq_rep_scie)[np.where(np.array(spws_scie) == spw_line)[0]] |
Collaborator
There was a problem hiding this comment.
Suggested change
| freq_rep_line = np.array(freq_rep_scie)[np.where(np.array(spws_scie) == spw_line)[0]] | |
| freq_rep_line = np.array(freq_rep_scie)[np.array(spws_scie) == spw_line] |
Collaborator
There was a problem hiding this comment.
Let's simplify here but otherwise this is what I was hacking in, too
e-koch
reviewed
Apr 13, 2023
|
|
||
| # AKL - had to cast lists -> array then index with 0 | ||
| freq_rep_line = np.array(freq_rep_scie)[np.where(np.array(spws_scie) == spw_line)[0]] | ||
| chan_width_line = (np.array(chan_width_scie)[np.where(np.array(spws_scie) == spw_line)[0]])/1e6 |
Collaborator
There was a problem hiding this comment.
Suggested change
| chan_width_line = (np.array(chan_width_scie)[np.where(np.array(spws_scie) == spw_line)[0]])/1e6 | |
| chan_width_line = (np.array(chan_width_scie)[np.array(spws_scie) == spw_line]) / 1.e6 |
e-koch
reviewed
Apr 13, 2023
| # AKL - had to cast lists -> array then index with 0 | ||
| freq_rep_line = np.array(freq_rep_scie)[np.where(np.array(spws_scie) == spw_line)[0]] | ||
| chan_width_line = (np.array(chan_width_scie)[np.where(np.array(spws_scie) == spw_line)[0]])/1e6 | ||
| num_chan_line = np.array(num_chan_scie)[np.where(np.array(spws_scie) == spw_line)[0]] |
Collaborator
There was a problem hiding this comment.
Suggested change
| num_chan_line = np.array(num_chan_scie)[np.where(np.array(spws_scie) == spw_line)[0]] | |
| num_chan_line = np.array(num_chan_scie)[np.array(spws_scie) == spw_line] |
Collaborator
Author
There was a problem hiding this comment.
Adjusted - I like this approach better too
Collaborator
|
@akleroy -- finally pushed the fixes to the slicing, including splitting out the relevant functions out of analysisUtils. |
Collaborator
|
Also pinging @thomaswilliamsastro -- probably separate from the import issue you were fighting with, but we'll need to merge the SD pipeline changes here for the pipeline to work on >6.3 (I think) |
thomaswilliamsastro
force-pushed
the
akl_branch
branch
from
584e18c to
96793d9
Compare
Collaborator
|
There was a conflict here, resolved and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches some small syntax stuff in the single dish pipeline.