Fix feather vs mosaic workflow issue in postprocessing#247
Merged
akleroy merged 1 commit intoPhangsTeam:masterfrom Oct 21, 2024
Merged
Fix feather vs mosaic workflow issue in postprocessing#247akleroy merged 1 commit intoPhangsTeam:masterfrom
akleroy merged 1 commit intoPhangsTeam:masterfrom
Conversation
akleroy
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some workflow control code to ensure:
(1) the first round of feathering is only applied on individual parts (i.e., not full mosaics),
(2) the mosaicking step is not done on unfeathered data when
feather_before_mosaic=True,(3) when
feather_before_mosaic=True, the output image has the right naming convention to be picked up by the following task in the pipeline (i.e., cleanup).Also removed the redundant
feather_after_mosaickeyword.These edits shouldn't affect most existing use case where the
feather_before_mosaickeyword is left asFalseby default. But they should allow end-to-end processing when it is set toTrueon purpose.