Merged
Conversation
Collaborator
Author
|
Don't merge this yet. I'm still testing locally. |
Collaborator
Author
|
Overdue update: this worked fine for the LGLBS cases where we were encountering contsub issues. |
thomaswilliamsastro
approved these changes
Aug 8, 2025
Collaborator
thomaswilliamsastro
left a comment
thomaswilliamsastro
left a comment
There was a problem hiding this comment.
Good to see this actually implemented now, rather than my hack to just use the old one...just for my benefit, have you run any tests just to see if this new task produces the same results as the old uvcontsub? It'd be good to know if anything changes and if so, by how much
Collaborator
Author
|
No, I haven't compared to the old uvcontsub outputs. though there's not much we can do about discrepancies and those should be captured upstream in CASA testing. (which doesn't mean we shouldn't compare for a few cases!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds handling for the new uvcontsub task inputs (CASA >=6.5.2). Though note that some options are no longer available to the new task (e.g. spw combination).
Also adds a new line config input parameter
flag_edge_fractionthat avoids using a fraction of the channels near the edge of a SPW. This seems to improve contsub fitting for >4 MHz EVLA HI SPWs. Default is 0.0 so will otherwise have no effect from previous default behaviour.