added masking of rolled spectra to shuffling.#261
Merged
Conversation
low-sky
approved these changes
Aug 28, 2025
phangsPipeline/scStackingRoutines.py
Outdated
|
|
||
| # ... also mask the region where the spectrum "wrapped" due to the FFT | ||
|
|
||
| max_channel = len(spaxis)*1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added masking of the "rolled around" channels in Shuffling.
I tested this on M31 and M33 ALMA and IRAM and it looks okay but I think there are some spaces to optimize. In particular I wasn't sure how zip worked on the last step - if it can be relied on to produce a constant size could move the channel grid creation out of the loop and save a bit. I'm sure there's some other cleverness possible too. But it seems to work (but also please check!).
If no one has time I'll just merge and people can shout as they hit bugs. Right now the behavior is bad in master so it's not a huge loss.