Conversation
Collaborator
Author
|
Hopefully this tidying also makes it a little easier to maintain going forwards |
e-koch
approved these changes
Nov 18, 2025
thomaswilliamsastro
force-pushed
the
casa-67
branch
from
4ca2c2f to
ddfd43f
Compare
Collaborator
Author
|
Tested with both the pip-installed CASA and monolithic versions, no crashes. Good to review @akleroy |
Collaborator
Author
|
Reverting to draft for now, for some reason feathering doesn't seem to be working |
- Remove duplicate imports - General tidy up of imports - Format for readability - Ensure IDs for selection in SD pipeline are ints - Account for getargspec being deprecated since Python 3.11 in VisRoutines - Trim SD cube - Add degenerate axes to fix feather crash
thomaswilliamsastro
force-pushed
the
casa-67
branch
from
ddfd43f to
a3f937b
Compare
Collaborator
Author
Collaborator
|
What ended up being the issue with the feathering? |
e-koch
approved these changes
Nov 25, 2025
Collaborator
Author
Seems like there's been some update where it needs the Stokes axis in there, since there's some sanity checks that all the axes are the same size and there's 4 of them. I've just added a line where if it doesn't exist, it'll add it. Annoying to find but pretty simple to fix |
akleroy
approved these changes
Dec 1, 2025
Collaborator
|
These look great - thanks Tom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing with the pip-installed CASA (required updating CASA AU), will also test with the monolithic version. Draft until then