SingleDish pipeline can now handle multiple MS's#280
Conversation
e-koch
left a comment
There was a problem hiding this comment.
This looks good to me from reviewing the code; most of the changes being the loop over EBs that, I think, shouldn't change the other SD pipeline steps.
@thomaswilliamsastro did you hit any other snags from local testing?
And @1054 , if you also have time to look through the changes, that would be great! You have a much better understanding of the SD pipeline than I do.
|
Only other thing I changed (and maybe it's not necessary) is for the imaging it'll pull the mean frequency from the concatenated MS, rather than the first one concatted. There might be a potential crash if |
08c30c2 to
6a8ad30
Compare
- SingleDish pipeline can now handle multiple MS's Also a little general code tidy-up, to improve readability
6a8ad30 to
5894943
Compare
|
@thomaswilliamsastro good to merge this on? I'll need to handle rebasing for #281 |
|
@e-koch it's rebased here, so good to merge. I guess this might end up being irrelevant with your revamp, but hey |
Also a little general code tidy-up, to improve readability