Skip to content

SingleDish pipeline can now handle multiple MS's#280

Merged
e-koch merged 1 commit intomasterfrom
multi-ms-tp
Jan 16, 2026
Merged

SingleDish pipeline can now handle multiple MS's#280
e-koch merged 1 commit intomasterfrom
multi-ms-tp

Conversation

@thomaswilliamsastro
Copy link
Copy Markdown
Collaborator

  • SingleDish pipeline can now handle multiple MS's

Also a little general code tidy-up, to improve readability

Copy link
Copy Markdown
Collaborator

@e-koch e-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from reviewing the code; most of the changes being the loop over EBs that, I think, shouldn't change the other SD pipeline steps.

@thomaswilliamsastro did you hit any other snags from local testing?

And @1054 , if you also have time to look through the changes, that would be great! You have a much better understanding of the SD pipeline than I do.

@e-koch e-koch requested a review from 1054 December 16, 2025 01:18
@thomaswilliamsastro
Copy link
Copy Markdown
Collaborator Author

Only other thing I changed (and maybe it's not necessary) is for the imaging it'll pull the mean frequency from the concatenated MS, rather than the first one concatted. There might be a potential crash if phcenter is not defined in that function call, but from the pipeline logic it's always passed along so I didn't see it come up

- SingleDish pipeline can now handle multiple MS's

Also a little general code tidy-up, to improve readability
@e-koch
Copy link
Copy Markdown
Collaborator

e-koch commented Jan 15, 2026

@thomaswilliamsastro good to merge this on? I'll need to handle rebasing for #281

@thomaswilliamsastro
Copy link
Copy Markdown
Collaborator Author

@e-koch it's rebased here, so good to merge. I guess this might end up being irrelevant with your revamp, but hey

@e-koch e-koch merged commit 18520fe into master Jan 16, 2026
@e-koch e-koch deleted the multi-ms-tp branch January 16, 2026 12:29
@e-koch e-koch mentioned this pull request Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants