Merged
Conversation
Collaborator
|
This makes me happy. Do you have any metrics on how much faster this ends up being? |
Collaborator
Author
|
Immense improvements for heavily oversampled beams (>factor of 10). For reasonable pixels per beam, it's a factor of a few. There are some issues with the heavily oversampled beams and the largest scales of convolution. There's clearly not good spectral sampling in this case and there's signal in the noise. That's a separate issue so this can be looked at now. |
- Accelerate noise generation - Trapping cases where box is large - Add padding to stop wrapping pathologies. Allow old method as (bad) option - Strip out debugging prints
thomaswilliamsastro
force-pushed
the
master
branch
from
d7d3863 to
291567f
Compare
Collaborator
|
Looks good to me, I've squashed/rebased and done a little tidy up. I think this is good to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speedups for noise generation. Profiling suggests the big problem was in the convolution being "not FFT" rather than in stride issues but these are implemented anyways.