Conversation
| public OAuthType findOAuthTypeByEmail(String email) { | ||
| return playerRepository.getOAuthTypeByEmail(email) | ||
| .orElseThrow(() -> { | ||
| logger.warn("[findOAtuhTypebyEmail] 존재하지 않는 email, email={}", email); |
There was a problem hiding this comment.
There is a typo in the log message: 'findOAtuhTypebyEmail' should be corrected to 'findOAuthTypeByEmail'.
Suggested change
| logger.warn("[findOAtuhTypebyEmail] 존재하지 않는 email, email={}", email); | |
| logger.warn("[findOAuthTypeByEmail] 존재하지 않는 email, email={}", email); |
Comment on lines
+61
to
+62
| int exp = player.increaseLevelPoint(point).getExp(); | ||
| playerRepository.save(PlayerConverter.toEntity(player)); |
There was a problem hiding this comment.
Ensure that the updated player state returned by increaseLevelPoint is the same instance being persisted. If increaseLevelPoint creates a new instance, consider storing that instance in a variable and passing it to PlayerConverter.toEntity before saving.
Suggested change
| int exp = player.increaseLevelPoint(point).getExp(); | |
| playerRepository.save(PlayerConverter.toEntity(player)); | |
| Player updatedPlayer = player.increaseLevelPoint(point); | |
| int exp = updatedPlayer.getExp(); | |
| playerRepository.save(PlayerConverter.toEntity(updatedPlayer)); |
Jeong-Rae
added a commit
that referenced
this pull request
Apr 5, 2025
* refactor: 디렉토리 위치 변경 * refactor(PlayerDetail): player details 정보 레이어 분리 * refactor(PlayerProfile): 플레이어 Profile 조회 리펙토링 * refactor: port 패키지 위치 변경
Jeong-Rae
added a commit
that referenced
this pull request
Apr 5, 2025
* [Player] Player 레이어드 구조 리펙토링 (#163) * refactor: 디렉토리 위치 변경 * refactor(PlayerDetail): player details 정보 레이어 분리 * refactor(PlayerProfile): 플레이어 Profile 조회 리펙토링 * refactor: port 패키지 위치 변경 * refactor: Email 전송 구조 리펙토링 * refactor: 패키지명 authentication -> account로 변경 * refactor: JWT 인증 객체 TokenPlayer 추가 * refactor: Account Service 로직 Player 마이그레이션 * refactor: PlayerValidator 레이어 위치 변경 * refactor: PlayerProfile DTO 구성 변경 * refactor: 소셜 로그인 공통 로직 분리 및 파싱 로직 구조화 * refactor: 토큰 및 이메일 중복 로직 클래스 분리
Jeong-Rae
added a commit
that referenced
this pull request
Dec 16, 2025
This reverts commit 28ed87d.
Jeong-Rae
added a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
플레이어 레이어드 구조를 리펙토링 합니다.
Description
Application -> core , infra
Infra -> core
구조의 의존성을 부여합니다.