Skip to content

Feature/api 7/endpoint signup#10

Merged
CarlosDev73 merged 6 commits into
devfrom
feature/API-7/endpoint-signup
Mar 11, 2025
Merged

Feature/api 7/endpoint signup#10
CarlosDev73 merged 6 commits into
devfrom
feature/API-7/endpoint-signup

Conversation

@CarlosDev73
Copy link
Copy Markdown
Contributor

prototipo funcional de la función registrar
El PR del prototipo lleva varios detalles importantes que estaremos usando.

  1. El endpoint de registrar funcionando para cualquier tipo de pruebas.
  2. Solucion a fallas en final de cada línea para usuarios de Windows.
  3. Uso de la librería class – validator y class transform (es de ts y la sugiere el propio nestjs)
    (https://docs.nestjs.com/pipes)

Copy link
Copy Markdown
Member

@andres15alvarez andres15alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mueve la logica correspondiente a usuario a su modulo.
@iabrahaamxs tambien puedes revisar el PR para tener otro POV

Comment thread src/auth/auth.controller.ts Outdated
Comment thread src/auth/auth.service.ts Outdated
Comment thread src/auth/auth.service.ts Outdated
Comment thread src/auth/dto/signUp.dto.ts Outdated
Comment thread src/user/dto/users.dto.ts
Comment thread src/user/dto/users.dto.ts
Comment thread src/auth/auth.service.ts Outdated
Copy link
Copy Markdown
Member

@andres15alvarez andres15alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CarlosDev73 CarlosDev73 merged commit 5a395d3 into dev Mar 11, 2025
@CarlosDev73 CarlosDev73 deleted the feature/API-7/endpoint-signup branch March 11, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants