feature/API-64/notify-order-update-only-by-socket#95
Merged
andres15alvarez merged 2 commits intoMay 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new WebSocket DTO (
UpdateDeliveryWsDTO) and updates theOrderGatewayto handle delivery updates via WebSocket. It also includes improvements to error handling, validation, and role-based access control for the new functionality.New DTO and WebSocket Integration:
src/order/dto/order-delivery.dto.ts: Added a new DTO class,UpdateDeliveryWsDTO, to handle delivery updates via WebSocket. It includes fields for the delivery ID, status, and optional employee ID, with appropriate validation and metadata decorators.src/order/order.gateway.ts: Imported the newUpdateDeliveryWsDTOto support the delivery update functionality.Gateway Enhancements:
src/order/order.gateway.ts: Added a new WebSocket event handler,updateDelivery, to update delivery information. This handler validates the incoming data, checks user permissions, and emits adeliveryUpdatedevent to notify relevant users about the update.Validation and Error Handling:
src/order/order.gateway.ts: IntegratedValidationPipefor structured validation of incoming WebSocket messages, with a custom exception factory to raiseWsExceptionon validation errors.Role-Based Access Control:
src/order/order.gateway.ts: AppliedAuthGuardWsandRolesGuardWsto theupdateDeliverymethod, restricting access to users withADMINorBRANCH_ADMINroles.