Graph viewport not changed after call to movieViewToX

[gopi1410]

In my code I do a call to

    mChart.moveViewToX(data.getXValCount() - 11);
    mChart.invalidate();

I keep on adding data dynamically to the chart the above code is executed after each data addition.
Sometimes the chart does not change the viewport and after the next data, it changes.

I looked in the issue and I noted that if I call invalidate() once again after a second or so of adding the data then the chart moves. Upon further examining the issue, the found that the issue was due to not refreshing the chart upon completion of the post() job. In the ViewPortHandler.java class, if I change the refresh(save, view, false); to refresh(save, view, true);, then my chart renders as desired. Is there any reason why you aren't refreshing after changing the viewport?

[gopi1410]

P.S. I am drawing a line chart, with multiple fill colours (i.e. one fill colour for dataset values above a specified limit and another fill colour for values below the limit) by using multiple datasets. IMO it would be an interesting demo to be added in your demo app. Let if know if I should send a pull request for the same :)

[PhilJay]

Are you doing anything different than this: https://github.com/PhilJay/MPAndroidChart/blob/master/MPChartExample/src/com/xxmassdeveloper/mpchartexample/DynamicalAddingActivity.java ?

Because there it is working.

[gopi1410]

Yes its almost the same thing except that I am making the datasets with colour filled (so maybe slower rendering than the demo). Also in the demo (DynamicalAddingActivity.java), sometimes the viewport doesn't move to the next value on addition. I am testing it on samsung galaxy tab S, haven't checked on other devices.
I also wanted to know why isn't the view getting refreshed in the moveViewToX function. As far I could understand in the code, it's being executed in the View.post queue (the MoveViewJob class). So, if the next call to chart.invalidate() is called earlier than the callback of View.post job, then the chart will not be updated.

[PhilJay]

Hmmmm that's weird.
Is your chart in a regular activity? Or inside some fragment or custom view?

[gopi1410]

Yes, in a regular activity. Also when the viewport is not moving upon a particular data, if I touch/tap the screen before adding the next data, the viewport moves to the correct position, I guess this is because of invalidate being called on touch (which was not called earlier after the job completed callback)
.

[PhilJay]

Yes, that could be an issue, I will look into it

[PhilJay]

Please have another go at it now, I just pushed the (a possible) fix.

[gopi1410]

Great. Verified. Working smoothly.

[joshfriend]

👍 fixed for me as well!