Open
Conversation
Contributor
|
You should add it in MainActivity as well. I did it to understand how does it looks like |
hannesa2
reviewed
Mar 28, 2026
| * @param buffer The buffer to fill | ||
| * @param dataSet The dataset containing time interval data | ||
| */ | ||
| protected void feedTimeIntervalBuffer(BarBuffer buffer, IBarDataSet dataSet) { |
Contributor
There was a problem hiding this comment.
It's not used at all. Without using it, it comes with the taste of useless
| if (mInverted) { | ||
| left = y >= yStart ? y : yStart; | ||
| right = y <= yStart ? y : yStart; | ||
| left = y >= posY ? y : posY; |
Contributor
There was a problem hiding this comment.
But to be honest, I don't get it why you removed yStart and calculate it this way.
| * @param timeIntervals Array of [start1, duration1, start2, duration2, ...] | ||
| * @return BarEntry configured for time interval rendering | ||
| */ | ||
| public static BarEntry createMultiSegmentEntry(float taskIndex, float[] timeIntervals) { |
Contributor
There was a problem hiding this comment.
As it is unused, it would be nice to have a demo usage for this too
| * @param data Custom data object | ||
| * @return BarEntry configured for time interval rendering with data | ||
| */ | ||
| public static BarEntry createTimeIntervalEntry(float taskIndex, float startTime, |
Contributor
There was a problem hiding this comment.
As it is unused, it would be nice to have a demo usage for this too
Contributor
|
Btw, look at the other pull requests, then you see it will be never merged. If you want to have merged, I invite you to contribute in this much more modern fork https://github.com/AppDevNext/AndroidChart |
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Mar 28, 2026
Inspired by PhilJay#5519
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Mar 28, 2026
Inspired by PhilJay#5519
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Mar 28, 2026
Inspired by PhilJay#5519
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Mar 28, 2026
Inspired by PhilJay#5519
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Mar 28, 2026
Inspired by PhilJay#5519
hannesa2
added a commit
to AppDevNext/AndroidChart
that referenced
this pull request
Mar 28, 2026
Inspired by PhilJay#5519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
PR Description