In RA2 Civilian Spy causes error

[CCCP84]

Description

The mere presence of a civilian spy on the map does not cause an error. However, when hovering the screen over him, an error immediately occurs. I have a suspicion that Civilian SPY is disguised by default as Yuri's INIT (in YR mode for some reason it's disguised as INIT) , so that in RA2 mode, this leads to an error.
If a Civilian spy is standing under a working Soviet psi-sensor and the disguise is removed, the units are displayed as spies and the error does not occur. When selling the psi-sensor, an immediate error occurs.
It must be disguised as a Soviet soldier when civilian in both modes, YR and RA2.

A similar problem existed before, but it was worse: back then, the spy was disguised as INIT even for players, but now, it seems, it only affects civilians.

#1158

https://discord.com/channels/338055131666972683/773636942775582720/1151547683643859027

Phobos Version

0.4.0.2

[CCCP84]

CnCNet/cncnet-yr-client-package#875

[Starkku]

Not Phobos issue, happens on CnCNet YR without Phobos.dll present.

[Starkku]

Closed prematurely, cannot reproduce the crash (need more info). Ultimately this is a problem created by invalid configuration however so not particularly high priority.

[CCCP84]

Here is Test Map:

spy test.zip

Spies are on center. Just move screen to center to get error in RA2, or to see Spy as Initiate in YR.

The problem is not really very pressing because there are probably very few maps in which a Civilian spy is already located, if any at all.
However, I think it is theoretically possible that in a completely normal game a spy will turn out to be a civilian. This is the case when a player who captured an undisguised spy with Yuri leaves the game or loses. Or Yuri, which captured the spy, will die. In this case, the spy remains on the map as a civilian and an error will occur in RA2.

Method "set [General]->ThirdDisguise to E1" probably isn't very good because, as I understand it, the spy created by Yuri's side will be disguised in that case as a soviet soldier. The solution here is probably to assign the Sovietdisguise as the default.

[Starkku]

Method "set [General]->ThirdDisguise to E1" probably isn't very good because, as I understand it, the spy created by Yuri's side will be disguised in that case as a soviet soldier. The solution here is probably to assign the Sovietdisguise as the default.

Isn't the error present only in RA2 mode where Yuri is not playable?

[CCCP84]

That's exactly it. But I don't understand how it's disguised as Init in RA2 mode if there's no at all thirddisguise in RA2 Rules.

Well, for Yuri's revenge, this is also a small problem, since although no mistakes occur, the spy is disguised incorrectly.

[CCCP84]

Now I understand what you're talking about. The thing is that in Red Alert 2 mode, the Soviet side can produce Yuris.

[Starkku]

I am not talking about any of that nonsense, game is hardcoded to use ThirdDisguise for civilian sides as default disguise in Yuri's Revenge. This is the case in vanilla YR without Ares or Phobos and is still the case in CnCNet even when the game loads a rules.ini without ThirdDisguise which means it is a null type. This should not normally crash and instead cause the game to show blank (invisible) disguise but there's code in Phobos that doesn't sanity check the disguise type pointer which causes it to crash.

Which is why I suggested fixing it by adjusting the RA2 mode's rules INI to include ThirdDisguise with valid value but thats up to CnCNet maintainers ig. I'll fix the crash on Phobos' side later just in case but even if it doesn't crash it will produce invisible infantry.

[CCCP84]

Now I understand what you're talking about. Yes, that's a good idea indeed. In Ra2, there's no Yuri side, so it's possible to add this line without any compromise.