Fix inconsistencies with Strafing.Shots logic #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starkku
added
the
Minor
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Thrifinesma
reviewed
Feb 15, 2025
DeathFishAtEase
force-pushed
the
develop
branch
from
2128644 to
799ea22
Compare
|
I adjusted the Strafing.EndDelay to 10. Which is the undesired behaviour? |
Contributor
|
tested and worked |
Coronia
pushed a commit
that referenced
this pull request
Mar 28, 2025
- Fixes an issue where last shot of strafing aircraft weapon with `Strafing.Shots` < 5 or if interrupted by ammo running out if `Strafing.UseAmmoPerShot=true` would not be followed by a similar delay before resuming strafing run or returning to base as there would otherwise be. The delay is also now explicitly customizable although I urge caution in using it in certain cases. --------------------------------- - `Strafing.EndDelay` can be used to override the delay after firing last shot in strafing run before aircraft resumes another strafing run or returns to base. Defaults to (Weapon `Range` * 256 + 1024) / Aircraft `Speed`. Note that using a short delay with aircraft that can do multiple strafing runs with their ammo can cause undesired behaviour. In `rulesmd.ini`: ```ini [SOMEWEAPON] ; WeaponType Strafing.EndDelay= ; integer, game frames ```
Metadorius
pushed a commit
to Metadorius/Phobos
that referenced
this pull request
Mar 30, 2025
- Fixes an issue where last shot of strafing aircraft weapon with `Strafing.Shots` < 5 or if interrupted by ammo running out if `Strafing.UseAmmoPerShot=true` would not be followed by a similar delay before resuming strafing run or returning to base as there would otherwise be. The delay is also now explicitly customizable although I urge caution in using it in certain cases. --------------------------------- - `Strafing.EndDelay` can be used to override the delay after firing last shot in strafing run before aircraft resumes another strafing run or returns to base. Defaults to (Weapon `Range` * 256 + 1024) / Aircraft `Speed`. Note that using a short delay with aircraft that can do multiple strafing runs with their ammo can cause undesired behaviour. In `rulesmd.ini`: ```ini [SOMEWEAPON] ; WeaponType Strafing.EndDelay= ; integer, game frames ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strafing.Shots< 5 or if interrupted by ammo running out ifStrafing.UseAmmoPerShot=truewould not be followed by a similar delay before resuming strafing run or returning to base as there would otherwise be. The delay is also now explicitly customizable although I urge caution in using it in certain cases.Strafing.EndDelaycan be used to override the delay after firing last shot in strafing run before aircraft resumes another strafing run or returns to base. Defaults to (WeaponRange* 256 + 1024) / AircraftSpeed. Note that using a short delay with aircraft that can do multiple strafing runs with their ammo can cause undesired behaviour.In
rulesmd.ini: