Fixes & improvements to electric bolt handling #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starkku
changed the title
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
Coronia
added
❓Phobos bug
Contributor
|
worked properly in testing |
CrimRecya
approved these changes
Mar 27, 2025
Coronia
pushed a commit
that referenced
this pull request
Mar 28, 2025
- Reverts the previous, partial or non-functional fixes for crash at `0x4C2C19`. - Replaces the code for handling tracking of electric bolts and their owner technos to support multiple electric bolt instances per techno (vanilla tracks this with single pointer in UnitClass only). This tracking code also correctly works for units in limbo which should prevent the aforementioned crash from occuring at all. - This tracking is used to determine whether or not the electric bolt updates its source coordinate based on FLH on every frame, allowing it to follow techno's rotation, movement etc. By default this is only enabled for vehicles just as before but can be overridden per weapon by explicitly setting value for `Bolt.FollowFLH`. It now correctly takes burst into accord thanks to changes mentioned in previous point. Fixes #1585
Metadorius
pushed a commit
to Metadorius/Phobos
that referenced
this pull request
Mar 30, 2025
- Reverts the previous, partial or non-functional fixes for crash at `0x4C2C19`. - Replaces the code for handling tracking of electric bolts and their owner technos to support multiple electric bolt instances per techno (vanilla tracks this with single pointer in UnitClass only). This tracking code also correctly works for units in limbo which should prevent the aforementioned crash from occuring at all. - This tracking is used to determine whether or not the electric bolt updates its source coordinate based on FLH on every frame, allowing it to follow techno's rotation, movement etc. By default this is only enabled for vehicles just as before but can be overridden per weapon by explicitly setting value for `Bolt.FollowFLH`. It now correctly takes burst into accord thanks to changes mentioned in previous point. Fixes Phobos-developers#1585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0x4C2C19.Bolt.FollowFLH. It now correctly takes burst into accord thanks to changes mentioned in previous point.Fixes #1585