Implementing RadType Enumeration #181

Otamaa · 2021-04-18T10:39:36Z

[RadiationTypes]
0=SOMERAD

[SOMERAD]
RadDurationMultiple=2
RadApplicationDelay=16
RadApplicationDelay.Building=0
RadLevelMax=500
RadLevelDelay=45
RadLightDelay=45
RadLevelFactor=0.2
RadLightFactor=0.1
RadTintFactor=2.5
RadColor=0,255,0
RadSiteWarhead=RadSiteWH

github-actions · 2021-04-18T10:42:17Z

Nightly build for this pull request:

compiled-dll-22c91e3a0be6fc04477bd2516f85dc3f7ccd5886.zip
This comment is automatic and is meant to allow guests to get latest nightly builds without registering. It is updated on every successful build.

Metadorius

Overall the code looks solid and a direct improvement over what was there previously. I left some code style notes in the review, would need to look at the stuff in details later.

Metadorius · 2021-04-18T10:45:27Z

src/Enum/RadTypes.cpp

+
+void RadType::LoadListSection(CCINIClass *pINI)
+{
+	const char *section = GetMainSection();


Should use this->GetMainSection(); to follow the code style.

Metadorius · 2021-04-18T10:45:39Z

src/Enum/RadTypes.cpp

+		const char *key = pINI->GetKeyName(section, i);
+		if (pINI->ReadString(section, key, "", Phobos::readBuffer)) 
+		{
+			FindOrAllocate(Phobos::readBuffer);


Metadorius · 2021-04-18T10:46:39Z

src/Enum/RadTypes.cpp

+	return "RadiationTypes";
+}
+
+RadType::RadType(const char* const pTitle)


I think to follow the YR scheme we could rename it to RadTypeClass? And also rename the file correspondingly.

Metadorius · 2021-04-18T10:49:17Z

src/Enum/RadTypes.cpp

+
+	INI_EX exINI(pINI);
+
+	this->RadWarhead.Read(exINI, section, "RadSiteWarhead" , true);


I think the variable names should follow the tag names exactly, with . being substituted with _.

Metadorius · 2021-04-18T10:51:03Z

src/Enum/RadTypes.cpp

+	}
+
+	for (size_t i = 0; i < Array.size(); ++i) 
+	{


Currently if the block is one-line (not broken up into multiple) we should use braceless single-line bodies instead.

Multiple RadSite on same area causing inf play mutiple death animation/generating multiple UnitToInf

experimental stuffs , it breaks Inf_AIDeploy_Check rad fix

-Deso cannot fire his weapon when cloaked (partialy fixed) -Unit with Death Weapon able to die twices (not affect yet)

-Deso cannot fire his Deploy weapon when cloaked (fixed)

* issue Phobos-developers#138 * Refactor and fix docs Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Update bug report template Semantic values for the Locomotor tag (Phobos-developers#169) * Semantic values for the Locomotor tag * Add docs entry Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Fix CellSetRadSite (Phobos-developers#173) Rename Update to AI Strafing aircraft weapon improvements. (Phobos-developers#174) * Strafing aircraft weapon improvements. - Add Strafing.Shots key to weapons that can be used to control number of shots fired during strafing run. - Add Strafing.SimulateBurst key to weapons that can be used to simulate firing offset-altering effect of Burst on Burst=1 strafing run weapons. - Fix to take Burst into account for shots beyond the first one, this also applies to Fighter=no aircraft without strafing pattern weapon. * Style pass and refactoring * Add image to documentation. Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Customizable amount of ore cells spawned per animation (Phobos-developers#180) * TerrainClass_AI_CellsPerAnim Uncommented ini-reader * Final pass at CellsPerAnim, docs Co-authored-by: Belonit <Belonit@ya.ru> Update feature_enhancement.md Create vanilla_bugfix_request.md Update .editorconfig Customizeable Teleport/Chrono Locomotor properties per attached Techno (Phobos-developers#142) * issue Phobos-developers#11 Phobos-developers#11 * Fix (i hate idiv ffs) * Fix wrong register causing Chronowarp broke * fix wrong return , set Warpout for all (WW default way) * Update Phobos.vcxproj * Update Hook.Teleport.cpp * Update Hook.Teleport.cpp * Using #define for more cleaner look * Update Doc with gif will rebase later when new mouse come * Update Doc * Refactoring, docs pass Co-authored-by: Belonit <Belonit@ya.ru> Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Improvements & minimum guard range for interceptor logic (Phobos-developers#188) * MinimumGuardRange added Adding MinimumGuardRange * Update Body.cpp Added MinimumGuardRange condition * Adding Interceptor.MinimumGuardRange function * Forgot IsAlly check * Adding my name to README.md Put my name on the credits * Adding Info about Interceptor Logic Adding info about `Interceptor.GuardRange`, `Interceptor.EliteGuardRange`, `Interceptor.MinimumGuardRange` and `Interceptor.EliteMinimumGuardRange` * Refactoring the stuff a bit Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Disable TreatWarningAsError Somebody should slap Belonit some day Shield logic improvements (Phobos-developers#185) * Weapon Select and Negative Damage * Small change * Change weapon select * Fix DeploysInto issue * Fix UndeploysInto issue * Update docs * Fix Versus (?) * Remove unused include * Shield Targeting now recognizes warhead, rather than damage * Fix targeting issue * Null check for anim * Shield health bar will be more like normal health bar * CONVEEEEEEEEEEEERT! * Small fix for UndeploysInto * Don't update shield when without, rather than delete * Small change for convert * Stupid issue * FIX stupid again * Refactor code and add info to docs * More support for Shield Armor * Additional check and Docs fix * Damage fix * Move the check out * Pass the check * fix more * Damn it Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Fix Harv-counter color closes Phobos-developers#187 "What's new" doc section Fix units dying multiple times during their death anims (Phobos-developers#190) * Fix vanilla bug - twice die * small fix * More checks * Separate hooks * Pass and docs Co-authored-by: Uranusian <mikesariitten@gmail.com> Implementing RadType Enumeration (Phobos-developers#181) * Implementing RadType Enumeration * Bug fix Multiple RadSite on same area causing inf play mutiple death animation/generating multiple UnitToInf * New Instances without Rely on Wepon experimental stuffs , it breaks Inf_AIDeploy_Check rad fix * Attempt to fix some known vanilla bugs -Deso cannot fire his weapon when cloaked (partialy fixed) -Unit with Death Weapon able to die twices (not affect yet) * Re-Cloak Deso when Undeployed -Deso cannot fire his Deploy weapon when cloaked (fixed) * Further changes * Removing unnessesary codes , fix some style , Doc * Refactorings Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Force C4Warhead PenetratesShield Fix shield SL issue Small refactor; version bump Change the check back to vanilla implement AnimList.PickRandom use ternary operator update for AnimList.PickRandom update code style Fix magnetron issue Phobos-developers#195 (Phobos-developers#200) Fix ranged mc desync (Phobos-developers#199) * Attempt to fix desync * Remove the check for player A pair of braces Bump version Remove `the Forgotten` Separate HP and cloak check of shield anim Fix lost HP check Contributing guidelines started; Git branching model info Skip the low damage check when techno has shield STUPID WW!!!!! closes Phobos-developers#204 First iteration of the styleguide

* Implementing RadType Enumeration * Bug fix Multiple RadSite on same area causing inf play mutiple death animation/generating multiple UnitToInf * New Instances without Rely on Wepon experimental stuffs , it breaks Inf_AIDeploy_Check rad fix * Attempt to fix some known vanilla bugs -Deso cannot fire his weapon when cloaked (partialy fixed) -Unit with Death Weapon able to die twices (not affect yet) * Re-Cloak Deso when Undeployed -Deso cannot fire his Deploy weapon when cloaked (fixed) * Further changes * Removing unnessesary codes , fix some style , Doc * Refactorings Co-authored-by: Meta (X230T) <crabiter@vivaldi.net>

Metadorius reviewed Apr 18, 2021

View reviewed changes

Otamaa force-pushed the feature/RadSite_Enumerable branch 4 times, most recently from a7281cc to b33f79e Compare April 21, 2021 15:44

Metadorius self-assigned this Apr 22, 2021

Otamaa force-pushed the feature/RadSite_Enumerable branch 3 times, most recently from 1139759 to 82041ba Compare April 24, 2021 16:35

Otamaa added 7 commits April 25, 2021 11:21

Implementing RadType Enumeration

c1ea9b4

Bug fix

bcf1ee7

Multiple RadSite on same area causing inf play mutiple death animation/generating multiple UnitToInf

New Instances without Rely on Wepon

bb31ee0

experimental stuffs , it breaks Inf_AIDeploy_Check rad fix

Attempt to fix some known vanilla bugs

37bf6bf

-Deso cannot fire his weapon when cloaked (partialy fixed) -Unit with Death Weapon able to die twices (not affect yet)

Re-Cloak Deso when Undeployed

681392d

-Deso cannot fire his Deploy weapon when cloaked (fixed)

Further changes

a3713da

Removing unnessesary codes , fix some style , Doc

16197a6

Metadorius force-pushed the feature/RadSite_Enumerable branch from 82041ba to f3813ba Compare April 25, 2021 11:14

Refactorings

f3813ba

Metadorius merged commit f9b156f into Phobos-developers:develop Apr 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Implementing RadType Enumeration #181

Implementing RadType Enumeration #181

Uh oh!

Otamaa commented Apr 18, 2021

Uh oh!

github-actions bot commented Apr 18, 2021 •

edited

Loading

Uh oh!

Metadorius left a comment

Uh oh!

Metadorius Apr 18, 2021

Uh oh!

Metadorius Apr 18, 2021

Uh oh!

Metadorius Apr 18, 2021

Uh oh!

Metadorius Apr 18, 2021

Uh oh!

Metadorius Apr 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		INI_EX exINI(pINI);

		this->RadWarhead.Read(exINI, section, "RadSiteWarhead" , true);

Uh oh!

Implementing RadType Enumeration #181

Implementing RadType Enumeration #181

Uh oh!

Conversation

Otamaa commented Apr 18, 2021

Uh oh!

github-actions bot commented Apr 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Metadorius left a comment

Choose a reason for hiding this comment

Uh oh!

Metadorius Apr 18, 2021

Choose a reason for hiding this comment

Uh oh!

Metadorius Apr 18, 2021

Choose a reason for hiding this comment

Uh oh!

Metadorius Apr 18, 2021

Choose a reason for hiding this comment

Uh oh!

Metadorius Apr 18, 2021

Choose a reason for hiding this comment

Uh oh!

Metadorius Apr 18, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Apr 18, 2021 •

edited

Loading