Fix units dying multiple times during their death anims #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
|
Thrifinesma
force-pushed
the
bugfix/twice-die
branch
2 times, most recently
from
ded08cd to
fc7f878
Compare
Thrifinesma
force-pushed
the
bugfix/twice-die
branch
from
201975d to
3fc08e7
Compare
Otamaa
added a commit
to Otamaa/Phobos
that referenced
this pull request
Apr 24, 2021
Create vanilla_bugfix_request.md Update .editorconfig Customizeable Teleport/Chrono Locomotor properties per attached Techno (Phobos-developers#142) * issue Phobos-developers#11 Phobos-developers#11 * Fix (i hate idiv ffs) * Fix wrong register causing Chronowarp broke * fix wrong return , set Warpout for all (WW default way) * Update Phobos.vcxproj * Update Hook.Teleport.cpp * Update Hook.Teleport.cpp * Using #define for more cleaner look * Update Doc with gif will rebase later when new mouse come * Update Doc * Refactoring, docs pass Co-authored-by: Belonit <Belonit@ya.ru> Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Improvements & minimum guard range for interceptor logic (Phobos-developers#188) * MinimumGuardRange added Adding MinimumGuardRange * Update Body.cpp Added MinimumGuardRange condition * Adding Interceptor.MinimumGuardRange function * Forgot IsAlly check * Adding my name to README.md Put my name on the credits * Adding Info about Interceptor Logic Adding info about `Interceptor.GuardRange`, `Interceptor.EliteGuardRange`, `Interceptor.MinimumGuardRange` and `Interceptor.EliteMinimumGuardRange` * Refactoring the stuff a bit Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Disable TreatWarningAsError Somebody should slap Belonit some day Shield logic improvements (Phobos-developers#185) * Weapon Select and Negative Damage * Small change * Change weapon select * Fix DeploysInto issue * Fix UndeploysInto issue * Update docs * Fix Versus (?) * Remove unused include * Shield Targeting now recognizes warhead, rather than damage * Fix targeting issue * Null check for anim * Shield health bar will be more like normal health bar * CONVEEEEEEEEEEEERT! * Small fix for UndeploysInto * Don't update shield when without, rather than delete * Small change for convert * Stupid issue * FIX stupid again * Refactor code and add info to docs * More support for Shield Armor * Additional check and Docs fix * Damage fix * Move the check out * Pass the check * fix more * Damn it Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Fix Harv-counter color closes Phobos-developers#187 "What's new" doc section Fix units dying multiple times during their death anims (Phobos-developers#190) * Fix vanilla bug - twice die * small fix * More checks * Separate hooks * Pass and docs Co-authored-by: Uranusian <mikesariitten@gmail.com>
Otamaa
added a commit
to Otamaa/Phobos
that referenced
this pull request
May 5, 2021
* issue Phobos-developers#138 * Refactor and fix docs Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Update bug report template Semantic values for the Locomotor tag (Phobos-developers#169) * Semantic values for the Locomotor tag * Add docs entry Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Fix CellSetRadSite (Phobos-developers#173) Rename Update to AI Strafing aircraft weapon improvements. (Phobos-developers#174) * Strafing aircraft weapon improvements. - Add Strafing.Shots key to weapons that can be used to control number of shots fired during strafing run. - Add Strafing.SimulateBurst key to weapons that can be used to simulate firing offset-altering effect of Burst on Burst=1 strafing run weapons. - Fix to take Burst into account for shots beyond the first one, this also applies to Fighter=no aircraft without strafing pattern weapon. * Style pass and refactoring * Add image to documentation. Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Customizable amount of ore cells spawned per animation (Phobos-developers#180) * TerrainClass_AI_CellsPerAnim Uncommented ini-reader * Final pass at CellsPerAnim, docs Co-authored-by: Belonit <Belonit@ya.ru> Update feature_enhancement.md Create vanilla_bugfix_request.md Update .editorconfig Customizeable Teleport/Chrono Locomotor properties per attached Techno (Phobos-developers#142) * issue Phobos-developers#11 Phobos-developers#11 * Fix (i hate idiv ffs) * Fix wrong register causing Chronowarp broke * fix wrong return , set Warpout for all (WW default way) * Update Phobos.vcxproj * Update Hook.Teleport.cpp * Update Hook.Teleport.cpp * Using #define for more cleaner look * Update Doc with gif will rebase later when new mouse come * Update Doc * Refactoring, docs pass Co-authored-by: Belonit <Belonit@ya.ru> Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Improvements & minimum guard range for interceptor logic (Phobos-developers#188) * MinimumGuardRange added Adding MinimumGuardRange * Update Body.cpp Added MinimumGuardRange condition * Adding Interceptor.MinimumGuardRange function * Forgot IsAlly check * Adding my name to README.md Put my name on the credits * Adding Info about Interceptor Logic Adding info about `Interceptor.GuardRange`, `Interceptor.EliteGuardRange`, `Interceptor.MinimumGuardRange` and `Interceptor.EliteMinimumGuardRange` * Refactoring the stuff a bit Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Disable TreatWarningAsError Somebody should slap Belonit some day Shield logic improvements (Phobos-developers#185) * Weapon Select and Negative Damage * Small change * Change weapon select * Fix DeploysInto issue * Fix UndeploysInto issue * Update docs * Fix Versus (?) * Remove unused include * Shield Targeting now recognizes warhead, rather than damage * Fix targeting issue * Null check for anim * Shield health bar will be more like normal health bar * CONVEEEEEEEEEEEERT! * Small fix for UndeploysInto * Don't update shield when without, rather than delete * Small change for convert * Stupid issue * FIX stupid again * Refactor code and add info to docs * More support for Shield Armor * Additional check and Docs fix * Damage fix * Move the check out * Pass the check * fix more * Damn it Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Fix Harv-counter color closes Phobos-developers#187 "What's new" doc section Fix units dying multiple times during their death anims (Phobos-developers#190) * Fix vanilla bug - twice die * small fix * More checks * Separate hooks * Pass and docs Co-authored-by: Uranusian <mikesariitten@gmail.com> Implementing RadType Enumeration (Phobos-developers#181) * Implementing RadType Enumeration * Bug fix Multiple RadSite on same area causing inf play mutiple death animation/generating multiple UnitToInf * New Instances without Rely on Wepon experimental stuffs , it breaks Inf_AIDeploy_Check rad fix * Attempt to fix some known vanilla bugs -Deso cannot fire his weapon when cloaked (partialy fixed) -Unit with Death Weapon able to die twices (not affect yet) * Re-Cloak Deso when Undeployed -Deso cannot fire his Deploy weapon when cloaked (fixed) * Further changes * Removing unnessesary codes , fix some style , Doc * Refactorings Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Force C4Warhead PenetratesShield Fix shield SL issue Small refactor; version bump Change the check back to vanilla implement AnimList.PickRandom use ternary operator update for AnimList.PickRandom update code style Fix magnetron issue Phobos-developers#195 (Phobos-developers#200) Fix ranged mc desync (Phobos-developers#199) * Attempt to fix desync * Remove the check for player A pair of braces Bump version Remove `the Forgotten` Separate HP and cloak check of shield anim Fix lost HP check Contributing guidelines started; Git branching model info Skip the low damage check when techno has shield STUPID WW!!!!! closes Phobos-developers#204 First iteration of the styleguide
Coronia
pushed a commit
to Coronia/Phobos
that referenced
this pull request
Mar 15, 2024
…opers#190) * Fix vanilla bug - twice die * small fix * More checks * Separate hooks * Pass and docs Co-authored-by: Uranusian <mikesariitten@gmail.com>
Coronia
pushed a commit
to Coronia/Phobos
that referenced
this pull request
Mar 15, 2024
…opers#190) * Fix vanilla bug - twice die * small fix * More checks * Separate hooks * Pass and docs Co-authored-by: Uranusian <mikesariitten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.