-
-
Notifications
You must be signed in to change notification settings - Fork 124
Typeselect consider ifv mode #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Coronia
merged 9 commits into
Phobos-developers:develop
from
NetsuNegi:origin/feature/typeselect
Nov 29, 2025
Merged
Typeselect consider ifv mode #1978
Coronia
merged 9 commits into
Phobos-developers:develop
from
NetsuNegi:origin/feature/typeselect
Nov 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
TaranDahl
requested changes
Nov 28, 2025
…egi/Phobos into origin/feature/typeselect
TaranDahl
approved these changes
Nov 29, 2025
Contributor
TaranDahl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other things LGTM.
DeathFishAtEase
added a commit
to DeathFishAtEase/Phobos
that referenced
this pull request
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
⚙️T1
T1 maintainer review is sufficient
Tested
❓Unhardcoding / Customization
Make something more tweakable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vanilla game, when using type selection command on IFVs, all of them will be selected regardless of their current modes, which is allowed to customize now.
WeaponGroupAsNdetermines which group the IFV is in when enablingWeaponN, where N stands for 1-based weapon mode index. IFVs in the same group will be selected together during type a selection, while not included those in different groups.TypeSelectUseIFVModedetermines whether all IFV modes will be considered as its own group by default during a type selection.WeaponGroupAsNwill be default to N for eachWeaponN, which makes each of them become a standalone type during a type selection.WeaponGroupAsNwill be default to 0 for all weapons, which makes type selection on IFVs work the same as before.In
rulesmd.ini: