Skip to content

Allow replacing vanilla repairing with togglable auto repairing#2031

Merged
TaranDahl merged 5 commits intoPhobos-developers:developfrom
TaranDahl:AutoRepair
Apr 22, 2026
Merged

Allow replacing vanilla repairing with togglable auto repairing#2031
TaranDahl merged 5 commits intoPhobos-developers:developfrom
TaranDahl:AutoRepair

Conversation

@TaranDahl
Copy link
Copy Markdown
Contributor

@TaranDahl TaranDahl commented Jan 7, 2026

Allow replacing vanilla repairing with togglable auto repairing

  • Now you can replace the vanilla repair method with a togglable auto-repair.

    • Pressing repair button or hotkey will no longer change your mouse, but will toggle your auto-repair state on/off.
    • When auto-repair state is toggled off, buildings will stop repairing.

    In rulesmd.ini:

[General]
ExtendedPlayerRepair=false    ; boolean

@TaranDahl TaranDahl added ❓New feature ⚙️T1 T1 maintainer review is sufficient Needs MP testing This PR needs to be tested for desync. labels Jan 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 7, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl TaranDahl force-pushed the AutoRepair branch 2 times, most recently from dc16047 to 0a10630 Compare March 2, 2026 04:27
@TaranDahl TaranDahl added Tested and removed Needs MP testing This PR needs to be tested for desync. labels Mar 2, 2026
@TaranDahl TaranDahl requested a review from NetsuNegi April 19, 2026 16:20
Copy link
Copy Markdown
Contributor

@ZivDero ZivDero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, the code is fine, but I'm not sold on the feature.
@Metadorius @Starkku thoughts?

Comment thread src/Ext/Event/Body.cpp Outdated
Comment thread CREDITS.md Outdated
@TaranDahl
Copy link
Copy Markdown
Contributor Author

TaranDahl commented Apr 20, 2026

but I'm not sold on the feature.

wdym 🤔
Any specific concern?

@ZivDero
Copy link
Copy Markdown
Contributor

ZivDero commented Apr 20, 2026

but I'm not sold on the feature.

wdym 🤔 Any specific concern?

Not really, would just like to get a second opinion.

@ZivDero
Copy link
Copy Markdown
Contributor

ZivDero commented Apr 20, 2026

Also, resolve merge conflicts plz.

Update Body.cpp

Update YRpp

Update Hooks.cpp

update
@TaranDahl
Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

@TaranDahl TaranDahl added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Apr 20, 2026
@TaranDahl
Copy link
Copy Markdown
Contributor Author

TaranDahl commented Apr 22, 2026

Going to merge this tonight if no further instructions. @ZivDero @Starkku @Metadorius

@TaranDahl TaranDahl changed the title Replace vanilla repairing with togglable auto repairing Allow replacing vanilla repairing with togglable auto repairing Apr 22, 2026
@TaranDahl TaranDahl merged commit 2d011d3 into Phobos-developers:develop Apr 22, 2026
6 checks passed
@TaranDahl TaranDahl deleted the AutoRepair branch April 22, 2026 15:12
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❓New feature ⚙️T1 T1 maintainer review is sufficient Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants