Decouple the calculations of TurretOffset and HeightShadowScaling#2137
Merged
Coronia merged 5 commits intoPhobos-developers:developfrom Mar 17, 2026
Merged
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
To Chinese users:
|
Coronia
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When drawing the shadow of an airborne unit, TurretOffset is applied to a transformation matrix that has already been scaled for height, causing the turret shadow's offset to be scaled as well and resulting in a misalignment with the actual turret image position.
Note
Example reproduction steps:
[DISK]unitShadowIndex=-1on both to hide the body shadowTurretOffsetto one of them to displace the turret by a certain distance512leptons as in the image below.TurretOffsetvalue. Check if the two turret shadows overlap.Before:

After:
