Skip to content

Allows defining whether passengers of an OpenTopped transport unit can fire when it is affected by a locomotor warhead#2182

Merged
Coronia merged 4 commits intoPhobos-developers:developfrom
DeathFishAtEase:locomotordeactivated
Apr 26, 2026
Merged

Allows defining whether passengers of an OpenTopped transport unit can fire when it is affected by a locomotor warhead#2182
Coronia merged 4 commits intoPhobos-developers:developfrom
DeathFishAtEase:locomotordeactivated

Conversation

@DeathFishAtEase
Copy link
Copy Markdown
Collaborator

@DeathFishAtEase DeathFishAtEase commented Apr 25, 2026

Allow using OpenTopped.AllowFiringIfDeactivated=false for the case where a transport unit is being attacked by a weapon that uses a warhead with IsLocomotor=true.

Use OpenTopped.AllowFiringIfAttackedByLocomotor to control whether the passengers of a non-building transport unit can fire when the unit is being attacked by a weapon whose warhead has IsLocomotor=true

@DeathFishAtEase DeathFishAtEase self-assigned this Apr 25, 2026
@DeathFishAtEase DeathFishAtEase added Needs testing ⚙️T1 T1 maintainer review is sufficient No Documentation Needed No documentation needed whatsoever labels Apr 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot
Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/375/1

@DeathFishAtEase DeathFishAtEase requested a review from Coronia April 25, 2026 16:14
@DeathFishAtEase
Copy link
Copy Markdown
Collaborator Author

Tested by https://www.phoboscn.top/t/topic/375/3
image

@TaranDahl TaranDahl added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Apr 26, 2026
@Coronia
Copy link
Copy Markdown
Contributor

Coronia commented Apr 26, 2026

I'm not sure if this needs a standalone tag, since locomotor change is a different scenario from EMP/deactivated

@DeathFishAtEase
Copy link
Copy Markdown
Collaborator Author

I'm not sure if this needs a standalone tag, since locomotor change is a different scenario from EMP/deactivated

Considering the accuracy issue of the INI flag name, it is indeed best to add a separate flag and allow setting a global default value to change the original behavior, rather than simply treating both as a deactivated state to handle them equivalently.

@DeathFishAtEase DeathFishAtEase changed the title Improve OpenTopped.AllowFiringIfDeactivated to take into account the state where a non-building transport unit is being attacked by a weapon that uses a warhead with IsLocomotor=true Allows defining whether passengers of an OpenTopped transport unit can fire when it is affected by a locomotor warhead Apr 26, 2026
@Starkku
Copy link
Copy Markdown
Contributor

Starkku commented Apr 26, 2026

Realistically the locomotor WH specifically disabling firing could be considered a special case of 'deactivation' but semantically I suppose it is clearer to split the two because of, as you put it, the 'accuracy issues' with the INI key name.

@Coronia Coronia merged commit e68f617 into Phobos-developers:develop Apr 26, 2026
6 checks passed
@DeathFishAtEase DeathFishAtEase deleted the locomotordeactivated branch April 26, 2026 12:13
DeathFishAtEase added a commit to DeathFishAtEase/Phobos that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Documentation Needed No documentation needed whatsoever ⚙️T1 T1 maintainer review is sufficient Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants