Fix tint color RGB mode conversion

[shatyuka]

The game's code looks weird because the switch case forgot to add break.

Has very little impact on the vanilla game:

TintColor	RGB565 Before	RGB565 After	RGB24 Before	RGB24 After
IronCurtain	0x0000	0x0000	#000000	#000000
ForceShield	0x0018	0x0018	#0000C6	#0000C6
Berserk	0xE000	0xC000	#E70000	#C60000

Vanilla Berserk tint in game:

Before	After

---

Update: Custom tint color for better comparison, R=21, G=21, B=0

RGB565 Before	RGB565 After	RGB24 Before	RGB24 After
0xFFE0	0xAAA0	#FFFF00	#AD5500

Custom tint in game:

Before	After

[github-actions]

Nightly build for this pull request:

• compiled-dll-33f66385fd850de26e511b7f20652492e75d5c85.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[DeathFishAtEase]

How was this PR tested? I don't seem to see a comparison of Berserk in vanilla YR before and after the changes in this PR, although I'm afraid we need to compare the color codes in the game screen to see the difference.

[shatyuka]

How was this PR tested? I don't seem to see a comparison of Berserk in vanilla YR before and after the changes in this PR, although I'm afraid we need to compare the color codes in the game screen to see the difference.

Comparison attached.

[Coronia]

The game's code looks weird because the switch case forgot to add break.

Has very little impact on the vanilla game:

TintColor RGB565 Before RGB565 After RGB24 Before RGB24 After
IronCurtain 0x0000 0x0000 #000000 #000000
ForceShield 0x0018 0x0018 #0000C6 #0000C6
Berserk 0xE000 0xC000 #E70000 #C60000
Vanilla Berserk tint in game:

Before After

Update: Custom tint color for better comparison, R=21, G=21, B=0

RGB565 Before RGB565 After RGB24 Before RGB24 After
0xFFE0 0xAAA0 #FFFF00 #AD5500
Custom tint in game:

Before After

if R and G have the same values, then the final RGB24 should still have R and G being the same I assume? While #FFFF00 is too deep of a yellow color, think it should at least be a shallow yellow after the fix?

[shatyuka]

if R and G have the same values, then the final RGB24 should still have R and G being the same I assume? While #FFFF00 is too deep of a yellow color, think it should at least be a shallow yellow after the fix?

No, it's RGB565, and the range of the green value is twice that of the red and blue.

Comment in [ColorAdd] section:

At the level that the blitters opperate, colors are 16 bit numbers, using the 5,6,5 RGB scheme. This
means that values of red range from 0 to 31, values of green from 0 to 63, and values of blue from 0
to 31.