Customizable OpenTopped Properties#374
Merged
Metadorius merged 5 commits intoPhobos-developers:developfrom Sep 25, 2021
Merged
Conversation
|
Nightly build for this pull request:
|
Member
|
I recommend to use Ares style tag naming like the following: OpenTopped.RangeBonus
OpenTopped.DamageMultiplier
OpenTopped.WarpDistance |
Thrifinesma
reviewed
Sep 21, 2021
Apply suggestion from code reviewer(2) Co-authored-by: Uranusian <45818100+Thrifinesma@users.noreply.github.com> Update src/Ext/Techno/Hooks.cpp Apply suggestion from code reviewer(s) Co-authored-by: Uranusian <45818100+Thrifinesma@users.noreply.github.com> Update src/Ext/Techno/Hooks.cpp Apply suggestion from code reviewer(s) Co-authored-by: Uranusian <45818100+Thrifinesma@users.noreply.github.com> Update src/Ext/Techno/Hooks.cpp Apply suggestion from code reviewer(s) Co-authored-by: Uranusian <45818100+Thrifinesma@users.noreply.github.com> Update src/Ext/Techno/Hooks.cpp Apply suggestion from code reviewer(s) Co-authored-by: Uranusian <45818100+Thrifinesma@users.noreply.github.com>
Otamaa
force-pushed
the
feature/Deharcode-Opentopped
branch
from
290375b to
9d641c7
Compare
Metadorius
requested changes
Sep 24, 2021
Member
Metadorius
left a comment
Metadorius
left a comment
There was a problem hiding this comment.
Code style is good mostly. Fix stuff pointed out in comments and add readme entry for your contribution.
Otamaa
force-pushed
the
feature/Deharcode-Opentopped
branch
from
8a11e60 to
8201d83
Compare
Metadorius
approved these changes
Sep 25, 2021
DeathFishAtEase
added a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7
this also partially solve #225
Customizable OpenTopped Properties
OpenToppedtransport locally