Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Add kwargs to loader#106

Merged
justusschock merged 2 commits intomasterfrom
loader_kwargs
Jul 13, 2020
Merged

Add kwargs to loader#106
justusschock merged 2 commits intomasterfrom
loader_kwargs

Conversation

@justusschock
Copy link
Copy Markdown
Member

@justusschock justusschock commented Jul 13, 2020

Short Description

Adds keyword arguments to support additional arguments like the new, but yet undocumented generator arg and also being backwards compatible.

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 13, 2020

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          36       36           
  Lines        1398     1398           
=======================================
  Hits         1368     1368           
  Misses         30       30           
Flag Coverage Δ
#unittests 97.85% <ø> (ø)
Impacted Files Coverage Δ
rising/loading/loader.py 95.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d707953...e27837b. Read the comment docs.

@justusschock justusschock self-assigned this Jul 13, 2020
@justusschock justusschock added the Bug Something isn't working label Jul 13, 2020
@justusschock justusschock merged commit 2a580e9 into master Jul 13, 2020
@justusschock justusschock deleted the loader_kwargs branch July 13, 2020 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants