Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Update loader.py to add DDP support#116

Merged
justusschock merged 1 commit intoPhoenixDL:masterfrom
ndalton12:patch-1
Jul 26, 2021
Merged

Update loader.py to add DDP support#116
justusschock merged 1 commit intoPhoenixDL:masterfrom
ndalton12:patch-1

Conversation

@ndalton12
Copy link
Copy Markdown
Contributor

@ndalton12 ndalton12 commented Mar 13, 2021

Short Description

This attribute lets ddp find the device correctly. GPU augmentations now work with DDP on multi-gpu!

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

This attribute lets ddp find the device correctly. GPU augmentations now work with DDP on multi-gpu!
@ndalton12 ndalton12 requested a review from justusschock as a code owner March 13, 2021 00:09
@justusschock justusschock merged commit ca0cf77 into PhoenixDL:master Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants