Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Pre-commit#117

Merged
justusschock merged 6 commits intoPhoenixDL:masterfrom
Borda:pre-commit
Aug 23, 2021
Merged

Pre-commit#117
justusschock merged 6 commits intoPhoenixDL:masterfrom
Borda:pre-commit

Conversation

@Borda
Copy link
Copy Markdown
Contributor

@Borda Borda commented Aug 22, 2021

Short Description

Adding pre-commit basic config, GHA and bot can be also enabled

PR Checklist

PR Implementer

This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the RisingTeam
and Reviewer workflows, the only purpose of those is to have a compact view of
the steps)

If there are any questions regarding code style or other conventions check out our
summary.

  • Implementation
  • Docstrings & Typing
  • Check __all__ sections and __init__
  • Unittests (look at the line coverage of your tests, the goal is 100%!)
  • Update notebooks & documentation if necessary
  • Pass all tests
  • Add the checksum of the last implementation commit to the Changelog

RisingTeam

RisingTeam workflow
  • Add pull request to project (optionally delete corresponding project note)
  • Assign correct label (if you don't have permission to do this, someone will do it for you.
    Please make sure to communicate the current status of the pr.)
  • Does this PR close an Issue? (add closes #IssueNumber at the bottom if
    not already in description)

Reviewer

Reviewer workflow
  • Do all tests pass? (Unittests, NotebookTests, Documentation)
  • Does the implementation follow rising design conventions?
  • Are the tests useful? (!!!) Are additional tests needed?
    Can you think of critical points which should be covered in an additional test?
  • Optional: Check coverage locally / Check tests locally if GPU is necessary to execute

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented Aug 22, 2021

I know, the problem is that there is the autopep8 bot that committed to the PR but as it is a bot it does not trigger any consecutive actions, this bot shall be replaced by https://pre-commit.ci/

Comment thread docs/source/conf.py Outdated
Comment thread docs/source/conf.py
@Borda
Copy link
Copy Markdown
Contributor Author

Borda commented Aug 22, 2021

@justusschock the docs is failing from master so it is unrelated to this PR :]

@Borda Borda requested a review from justusschock August 22, 2021 21:19
@Borda Borda mentioned this pull request Aug 23, 2021
14 tasks
@justusschock justusschock merged commit 047c279 into PhoenixDL:master Aug 23, 2021
@Borda Borda deleted the pre-commit branch February 22, 2023 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants