This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Contributor
Author
|
I know, the problem is that there is the autopep8 bot that committed to the PR but as it is a bot it does not trigger any consecutive actions, this bot shall be replaced by https://pre-commit.ci/ |
Contributor
Author
|
@justusschock the docs is failing from master so it is unrelated to this PR :] |
justusschock
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Adding pre-commit basic config, GHA and bot can be also enabled
PR Checklist
PR Implementer
This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the
RisingTeamand
Reviewerworkflows, the only purpose of those is to have a compact view ofthe steps)
If there are any questions regarding code style or other conventions check out our
summary.
__all__sections and__init__RisingTeam
RisingTeam workflow
Please make sure to communicate the current status of the pr.)
closes #IssueNumberat the bottom ifnot already in description)
Reviewer
Reviewer workflow
risingdesign conventions?Can you think of critical points which should be covered in an additional test?