fix: bump APScheduler bound to avoid pkg_resources import error#9
Open
akashkolakkal wants to merge 2 commits intoPhonePe:mainfrom
Open
fix: bump APScheduler bound to avoid pkg_resources import error#9akashkolakkal wants to merge 2 commits intoPhonePe:mainfrom
akashkolakkal wants to merge 2 commits intoPhonePe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the APScheduler dependency so installs resolve to versions that no longer import
pkg_resourcesat import time, fixingModuleNotFoundError: No module named 'pkg_resources'on Python 3.12+ and minimal virtualenvs where setuptools is not installed.Root cause
Older APScheduler versions import
pkg_resources(from setuptools) duringimport apscheduler.... APScheduler 3.10.2 and later useimportlib.metadatainstead.Changes
APScheduler>=3.10.2,<=3.11.2insetup.pyso pip cannot select a release that still triggers thepkg_resourcesimport, while keeping an upper bound on the 3.x line.Alternatives considered
Adding
setuptoolsas a direct dependency would mask the issue but keeps a deprecated import path; upgrading and constraining APScheduler is the cleaner fix for a library.Fixes #7