Skip to content

456 add part of speech tags to sign level information#461

Merged
gracemyz merged 9 commits intomainfrom
456-add-part-of-speech-tags-to-sign-level-information
Jul 22, 2025
Merged

456 add part of speech tags to sign level information#461
gracemyz merged 9 commits intomainfrom
456-add-part-of-speech-tags-to-sign-level-information

Conversation

@gracemyz
Copy link
Contributor

No description provided.

@gracemyz gracemyz requested a review from kchall July 13, 2025 23:19
@gracemyz gracemyz linked an issue Jul 13, 2025 that may be closed by this pull request
@gracemyz
Copy link
Contributor Author

@stannam just pushed -- could you double check the line edit now? thanks!

@kchall
Copy link
Member

kchall commented Jul 21, 2025

@gracemyz Confirming that the re-set does work for me again as before, thanks!

Copy link
Member

@stannam stannam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lineEdit is now looking good, thanks!

However, resizing the window shrinks it as below. Maybe consider setting a minimum height?

ScreenRecording2025-07-21at4 55 14PM-ezgif com-video-to-gif-converter

@gracemyz gracemyz merged commit 63f55e8 into main Jul 22, 2025
@kchall
Copy link
Member

kchall commented Jul 22, 2025

Ooh... @gracemyz the idea behind the minimum is good, but currently on my machine, the minimum actually cuts off the bottom row entirely so that I can't see that it's there unless I make the window bigger:

image

At least with the other version, I could see that there was another line that might be available if expanded, which I think is more intuitive? Sorry. :(

@gracemyz
Copy link
Contributor Author

gracemyz commented Jul 22, 2025

@kchall I've added a scrollbar -- does this fix the problem? sorry for all the back and forth...

(still on branch 456)

@kchall
Copy link
Member

kchall commented Jul 22, 2025

@gracemyz No, I'm sorry! :) Thanks, I think this works -- in an ideal world, the software would 'remember' a user's default window size the way it remembers their main window arrangement, but I think I can live with this for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add part-of-speech tags to Sign-Level Information

3 participants