Mulitag samples aren't properly filling in Client

[srimanachanta]

The sample count should be increasing with each new result but it isn't. See here, sample count is stuck at 8. Sometimes it will show NaN aswell.

Screen.Recording.2024-01-04.at.4.04.11.PM.mov

[randomstring]

I've seen this a couple times. Samples will stop updating. Reports NaN/100 samples.

I'll add that hitting the "RESET SAMPLES" button will sometimes lock up the UI, Firefox reports that the web page is using too much cpu. Only fix is to close the tab and reconnect.
[edit to add:}

When the UI locks up firefox reports "This page is slowing down firefox. To speed up your browser close this page."

stdev sampling seems to be dead more than it's alive. This is on latest dev build.

[srimanachanta]

I belive the fact that we are using a while loop to remove samples which the store is adding them is bad practice and relys on getting more samples then are removed, it should be redone. Not sure why samples are filling in but might also be related to that.

[Gold856]

I believe this was fixed in #1900. I specifically remember looking at Multitag when we doing the upgrade and it seemed to work much more reliably.