Skip to content

Conversation

@Gold856
Copy link
Collaborator

@Gold856 Gold856 commented Apr 13, 2025

Description

#884 says that PRs that update pipeline settings or anything related to data exchange should update the typing in the frontend as well, but that's not on the checklist. Add it to ensure we don't miss it.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner April 13, 2025 04:03
@Gold856 Gold856 enabled auto-merge (squash) April 13, 2025 04:06
Copy link
Member

@samfreund samfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gold856 Gold856 disabled auto-merge April 13, 2025 04:18
@Gold856 Gold856 enabled auto-merge (squash) April 13, 2025 04:18
@Gold856 Gold856 merged commit 925defc into PhotonVision:main Apr 13, 2025
39 checks passed
@Gold856 Gold856 deleted the add-update-to-checklist branch April 13, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants