Skip to content

Conversation

@Gold856
Copy link
Collaborator

@Gold856 Gold856 commented Jun 28, 2025

Description

#1978 fixed the modal not working, but the modal could not be closed, and navigation to the Camera Matching tab didn't work either. This is because v-model attempted to write to the read-only needsCamerasConfigured computed property, and since it couldn't be set to false, the modal stayed up. This has been changed so that a separate ref is used to track the state of the modal, which is more consistent with how other modals are set up. Navigation to the Camera Matching tab has also been fixed by using <router-link>. Finally, the warningShown and needsCamerasConfigured properties have been deduplicated and moved to the camera settings store, motivated by the fact that there's a typo in the photon-sidebar version (PlaceHolder instead of Placeholder).

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner June 28, 2025 22:52
@Gold856 Gold856 force-pushed the fix-needs-camera-config-dialog branch from c533390 to e85cf24 Compare June 28, 2025 22:54
@samfreund samfreund enabled auto-merge (squash) June 29, 2025 04:18
Copy link
Member

@samfreund samfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@samfreund samfreund merged commit cc7923e into PhotonVision:main Jun 29, 2025
39 checks passed
@Gold856 Gold856 deleted the fix-needs-camera-config-dialog branch June 29, 2025 04:27
@Gold856
Copy link
Collaborator Author

Gold856 commented Jul 11, 2025

I should also note this fixed the Camera Matching tab text being completely static. It now pulsates in red when cameras need configuring.

@Gold856 Gold856 added the frontend Having to do with PhotonClient and its related items label Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants